Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated annotation from Metadata.pubKeyCS #614

Closed
gkc opened this issue Jul 25, 2024 · 0 comments · Fixed by #615
Closed

remove deprecated annotation from Metadata.pubKeyCS #614

gkc opened this issue Jul 25, 2024 · 0 comments · Fixed by #615
Assignees
Labels
enhancement New feature or request

Comments

@gkc
Copy link
Contributor

gkc commented Jul 25, 2024

Is your feature request related to a problem? Please describe.

pubKeyCS is marked as deprecated but support for pubKeyHash (the proposed replacement) has not yet been added to at_server or at_client_sdk

Describe the solution you'd like

I think to prevent confusion we need to remove the deprecation annotation until at_server and at_client_sdk fully support pubKeyHash.

Additional context

While I was on a lint cleanup spree in at_secondary_server, I noticed that while there were lint info messages regarding pubKeyCS being deprecated, there was no mention of pubKeyHash anywhere in the at_server codebase, nor any of the other atsign-foundation repos. The annotation description, "use pubKeyHash" is therefore, currently, both misleading and bad advice.

@gkc gkc added the enhancement New feature or request label Jul 25, 2024
@gkc gkc self-assigned this Jul 25, 2024
@gkc gkc closed this as completed in #615 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant