Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptake pubKeyHash changes #1417

Closed
murali-shris opened this issue Oct 14, 2024 · 3 comments
Closed

Uptake pubKeyHash changes #1417

murali-shris opened this issue Oct 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

pubKeyCS used md5 checksum which is outdated

Describe the solution you'd like

  • in AbstractAtKeyEncryption, replace the call to EncryptionUtil.md5CheckSum with at_chops method. set pubKeyHash instead of pubKeyCS
  • in SharedKeyDecryption, replace the call to EncryptionUtil.md5CheckSum with at_chops.verify. Add backward compatibility check, if pubKeyCS is set.

Describe alternatives you've considered

No response

Additional context

No response

@murali-shris
Copy link
Member Author

Will plan to complete this in sprint 99.

@sitaram-kalluri
Copy link
Member

sitaram-kalluri commented Nov 25, 2024

Work accomplished in PR 100

The changes in at_commons are completed and published in v5.0.2.

The changes in at_client are completed and changes are available in 1417-uptake-pubkeyhash-changes

Pending work here is code review and merge the changes.

@sitaram-kalluri
Copy link
Member

The changes are published in v3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants