Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some e2e tests for APKAM-enrolled clients #1309

Closed
gkc opened this issue Apr 28, 2024 · 2 comments · Fixed by #1321
Closed

Need some e2e tests for APKAM-enrolled clients #1309

gkc opened this issue Apr 28, 2024 · 2 comments · Fixed by #1321
Assignees
Labels
bug Something isn't working Testing

Comments

@gkc
Copy link
Contributor

gkc commented Apr 28, 2024

Describe the bug

We have no e2e tests right now which prove that APKAM-enrolled atsign_1 can successfully communicate with APKAM-enrolled atsign_2

Expected behavior

Something like this in the e2e tests:

  • create and then approve an APKAM enrollment for atSign1
  • create and then approve an APKAM enrollment for atSign2
  • Test put, get, delete (and their auto-notifications) atSign1 to atSign2 using APKAM to APKAM, APKAM to pkam, pkam APKAM (in this shorthand terminology, pkam to pkam is what we currently test)
  • Ideally refactor existing e2e tests to extract out the common stuff so we can then run them with whichever combination we want (current: pkam to pkam)
@gkc gkc added bug Something isn't working Testing labels Apr 28, 2024
@gkc
Copy link
Contributor Author

gkc commented May 2, 2024

@sitaram-kalluri @murali-shris i have thoughts about how to do this easily, now that I've done this for NoPorts. I'll add a comment here over the weekend describing the approach

@sitaram-kalluri
Copy link
Member

Currently, the E2E tests are running successfully. The unit tests are failing with dart beta version due to following dart issue: dart-lang/sdk#55911 (comment). Pending work is to update the dependencies and check if the issue is resolved.

@gkc gkc closed this as completed in #1321 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants