Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End2end tests that pass without being able to reach another atServer #1133

Closed
cpswan opened this issue Oct 4, 2023 · 3 comments
Closed

End2end tests that pass without being able to reach another atServer #1133

cpswan opened this issue Oct 4, 2023 · 3 comments
Assignees

Comments

@cpswan
Copy link
Member

cpswan commented Oct 4, 2023

Describe the bug

24 tests passed, 25 failed. when ce2e1 couldn't connect to ce2e2 (and similarly ce2e3 & 4)

Steps to reproduce

  1. First I configure cicd atServers to connect to wrong atDirectory
  2. Then I run end2end tests
  3. And then many of them pass even though remote atServers are unreachable

https://github.com/atsign-foundation/at_client_sdk/actions/runs/6402358157/job/17384836340 provides an example

Expected behavior

End2end tests should only pass when another atServer is involved.

Tests that don't need another atServer should be refactored into functional tests.

If the run time for functional tests gets too long we can break them into batches.

Additional context

This happened whilst migrating the cicd atServers, and a bunch of them were pointed at the wrong root server and thus unable to connect to their opposite atServer
at_client_logs_3653.zip

@purnimavenkatasubbu
Copy link
Member

purnimavenkatasubbu commented Oct 30, 2023

Updated the tests and raised a PR Only PR review and merge are pending. Updating it to 2SP

@purnimavenkatasubbu
Copy link
Member

Tests have been refactored and PR merged to trunk. PR

@gkc
Copy link
Contributor

gkc commented Nov 14, 2023

Thank you @purnimavenkatasubbu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants