Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add personal hosts to /etc/hosts? #33

Open
lfbn opened this issue Apr 20, 2018 · 3 comments
Open

How to add personal hosts to /etc/hosts? #33

lfbn opened this issue Apr 20, 2018 · 3 comments

Comments

@lfbn
Copy link

lfbn commented Apr 20, 2018

Hi there,

I would like to add some personal hosts, but don't want them to be versioned. It makes sense to include this kind of customization? If not, we have always to manage files that should be committed and not.

Idea: add an extra file, something like /configs/hosts.custom that should be appended to /etc/hosts at the install.sh, and add that extra file to .gitignore?

@atomantic
Copy link
Owner

that could work--also I've migrated myself to use https://github.com/StevenBlack/hosts, which might be a better add in replacement for the hosts file in the repo...

@lfbn
Copy link
Author

lfbn commented Apr 23, 2018

Hi @atomantic,

Thanks. Do you mean use that repo it in parallel? Not included, right?

Can I create a PR adding this custom hosts to install.sh?

@atomantic
Copy link
Owner

yeah, either it could be added as a git submodule like oh-my-zsh, or part of the install script could clone the repo and run the hosts setup. With the submodule approach, the install script should probably do a git submodule update, but with the clone on demand approach it could just clone into /tmp. Either way seems fine.

Feel free to PR it -- you'll likely get to it before I do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants