Macro value of #define not highlighted separately to name

[cjastone]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

I recently raised the following issue: #299

This seems to be related to the above, which was fixed very quickly - good work by all!

The value immediately following the macro name is not highlighted and remains the same colour as the macro name,.

Steps to Reproduce

1. Create a line of code with #define (e.g. #define MACRO_NAME 123)
2. Observe that the text following the macro is not highlighted correctly.

Expected behavior: Macro itself would be in a separate colour (default grey in my instance)

Actual behavior: Macro is the same colour as the text of the name (default orange in my instance)

Reproduces how often: Consistently for the above example.

Versions

Atom : 1.32.1
Electron: 2.0.9
Chrome : 61.0.3163.100
Node : 8.9.3
Windows 10 1803

apm 2.1.2
npm 6.2.0
node 8.9.3 x64
atom 1.32.1

[Ben3eeE]

Thanks for the report 🙇

Having constant identifiers and constant literals colored the same is an expected change with tree-sitter. It seems like the scope applied in textmate was never really correct either since this was scoped as a function name #197.

@thomasjo Do you have any new thoughts about the naming and scopes we can use here?

Right now we scope MACRO_NAME in this issue report as contant.other and a function like macro is scoped as entity.name.function.preprocessor.