Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Warn users using metric thresholds #33

Open
kevinweber opened this issue Apr 26, 2020 · 1 comment
Open

Feature request: Warn users using metric thresholds #33

kevinweber opened this issue Apr 26, 2020 · 1 comment

Comments

@kevinweber
Copy link
Contributor

How we can provide better guidance to developers who usually don't work on performance? Here's an idea:

  • Allow setting a threshold for each metric to educate developers about what’s acceptable (e.g. 50ms for mounting a component)
  • If a threshold is exceeded, the metric should clearly stick out (see mockup below)
  • Developers should be able to override the default threshold for each metric

Render times and other metrics can change between runs and machines, and so does the performance in the real world! Calculating the rendering time of a component that runs on a development version of React and on a developer machine might be closer to the performance of components running on real world slow devices in production mode.

Therefore, the threshold should be met even on slow machines and when running uncompressed code.

@alexreardon
Copy link
Collaborator

alexreardon commented May 5, 2020

Interesting! This would be cool. I think the variance between machines will make it tricky, but keen if you want to have a look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants