Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align case study cards properly #3499

Closed
wants to merge 1 commit into from
Closed

fix: align case study cards properly #3499

wants to merge 1 commit into from
+2 −2

Conversation

Kalprajsinh
Copy link

@Kalprajsinh Kalprajsinh commented Dec 20, 2024 •
edited by coderabbitai bot
Loading

Fix: #3494

Description

  • Adjusted the layout styles to ensure that the cards are centered and equally spaced.
  • Added hover effects for better visual feedback on card interactions.
  • Updated CSS classes to improve alignment and responsiveness.

Screenshots

Before:
image

After:
image

Summary by CodeRabbit

  • New Features

    • Enhanced visual presentation of the Case Study Card component with improved layout and spacing.
    • Added shadow effects on hover for better visual depth.

  • Style

    • Updated layout classes for a more flexible design.
    • Increased spacing between items on larger screens.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2024 •
edited
Loading

Walkthrough

The CaseStudyCard component in the project has been updated with modifications to its layout and styling. The changes focus on improving the visual presentation and alignment of case study cards. The component now uses more flexible class names that enhance the centering and spacing of cards, with added hover effects to provide visual depth to the card elements.

Changes

File Change Summary
components/CaseStudyCard.tsx - Updated outer <div> layout classes from lg:grid lg:grid-cols-3 to use justify-center and items-start
- Modified gap classes from lg:gap-8 to lg:gap-20 gap-10
- Added shadow-sm hover:shadow-md to inner card <div> for enhanced visual effect

Assessment against linked issues

Objective Addressed Explanation
Align case study cards at the center of the screen [#3494] ✅
Ensure cards take up equal space with consistent vertical alignment [#3494] ✅

Poem

🐰 Hop, hop, cards align just right,
Shadows dancing with delight,
Centered view, no more despair,
Case studies now float on air!
A rabbit's design, clean and bright 🎨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24a52ca and e516d67.

📒 Files selected for processing (1)
  • components/CaseStudyCard.tsx (1 hunks)
🔇 Additional comments (2)
components/CaseStudyCard.tsx (2)

22-22: LGTM! Improved responsive layout and spacing.

The flex container now properly centers cards with consistent spacing across different screen sizes. The combination of justify-center with flex-wrap ensures proper alignment and wrapping behavior.

26-26: LGTM! Enhanced visual feedback with hover effects.

The card styling improvements with shadow-sm hover:shadow-md provide subtle but effective visual feedback on interaction, while maintaining clean aesthetics with consistent border and rounded corners.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

github-actions[bot]
github-actions bot reviewed Dec 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e516d67
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6765ba926af54000086df5f7
😎 Deploy Preview https://deploy-preview-3499--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 34
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3499--asyncapi-website.netlify.app/

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (24a52ca) to head (e516d67).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3499   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files          21       21           
  Lines         664      664           
=======================================
  Hits          575      575           
  Misses         89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kalprajsinh Kalprajsinh changed the title fix:#3494 alignment of case study cards fix #3494 alignment of case study cards Dec 20, 2024
@Kalprajsinh Kalprajsinh changed the title fix #3494 alignment of case study cards fix: align case study cards properly Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@akshatnema akshatnema Awaiting requested review from akshatnema akshatnema is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@anshgoyalevil anshgoyalevil Awaiting requested review from anshgoyalevil anshgoyalevil is a code owner

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@devilkiller-ag devilkiller-ag Awaiting requested review from devilkiller-ag

@sambhavgupta0705 sambhavgupta0705 Awaiting requested review from sambhavgupta0705

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Improper alignment of case study cards in case studies page
2 participants
@Kalprajsinh @asyncapi-bot