Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated index.tsx and fixed the gap problem at the last text at the bottom of the landing page #3491

Conversation

BalrajDhakad
Copy link

@BalrajDhakad BalrajDhakad commented Dec 19, 2024

Screenshots

Before Fix
Screenshot 2024-12-19 at 8 47 34 PM

After Fix
Screenshot 2024-12-19 at 8 47 40 PM

Description

Changed the text to fix the issue so that the gap is filled between the description and the author name, avatar and description.

Resolved issue
#3487

Summary by CodeRabbit

  • New Features
    • Enhanced testimonial text on the homepage, providing a more detailed perspective on the significance of event-driven APIs and expressing gratitude for contributors.

Copy link

coderabbitai bot commented Dec 19, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '@tisoap/[email protected]',
npm warn EBADENGINE required: { node: '>=16', npm: '^8.0.0' },
npm warn EBADENGINE current: { node: 'v22.9.0', npm: '10.8.3' }
npm warn EBADENGINE }
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: No longer actively maintained. Please use @makotot/ghostui instead.
npm warn deprecated [email protected]: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
npm warn deprecated [email protected]: Removed event-stream from gulp-header
npm warn deprecated [email protected]: Please upgrade to v9.0.0+ as we have fixed a public vulnerability with formidable dependency. Note that v9.0.0+ requires Node.js v14.18.0+. See ladjs/superagent#1800 for insight. This project is supported and maintained by the team at Forward Email @ https://forwardemail.net
npm warn deprecated [email protected]: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
npm warn deprecated @floating-ui/[email protected]: Package renamed to @floating-ui/react
npm warn deprecated [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

Walkthrough

The pull request introduces a modification to the testimonial text for Eric Horesnyi in the HomePage component of a language-specific page. The change expands the existing testimonial, providing a more comprehensive description of the AsyncAPI project's importance in event-driven API architectures. The modification is purely textual and does not alter the component's structure or functionality.

Changes

File Change Summary
pages/[lang]/index.tsx Updated testimonial text for Eric Horesnyi, expanding the description of AsyncAPI's significance

Poem

🐰 A Rabbit's Ode to Words Refined

In lines of code, a story grows
Eric's wisdom now brightly shows
AsyncAPI's tale, once brief and light
Now speaks with passion, burning bright!
A testimonial's gentle art
Reveals the project's beating heart 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c90b564 and 6035e45.

📒 Files selected for processing (1)
  • pages/[lang]/index.tsx (1 hunks)
🔇 Additional comments (2)
pages/[lang]/index.tsx (2)

222-222: Please clarify how this change fixes the gap issue

The PR description mentions fixing a gap between description text and author details, but the only change is updating testimonial text. Could you please:

  1. Explain how this text change addresses the layout issue
  2. Consider if additional CSS/layout changes are needed
  3. Provide before/after screenshots focusing on the specific gap being fixed

The testimonial text update itself looks good, but it's unclear if this alone resolves the reported layout problem.

Let's check the git history for any related layout fixes:


222-222: Verify testimonial content and layout impact

While the updated testimonial text is well-written and aligns with AsyncAPI's mission, please ensure:

  1. The testimonial change has been approved by Eric Horesnyi
  2. The longer text doesn't cause layout issues on mobile devices

Let's check for responsive design handling:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6035e45
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6764392f0d55570008f27136
😎 Deploy Preview https://deploy-preview-3491--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BalrajDhakad BalrajDhakad changed the title fix: Updated index.tsx and fixed the gap problem at the last text at the bottom of the landing page fix: updated index.tsx and fixed the gap problem at the last text at the bottom of the landing page Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (c90b564) to head (6035e45).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3491   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files          21       21           
  Lines         664      664           
=======================================
  Hits          575      575           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 34
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3491--asyncapi-website.netlify.app/

@anshgoyalevil
Copy link
Member

I would again have to close this PR. @BalrajDhakad Kindly restrain from opening such PRs without prior issue triage from one of the maintainers.

@BalrajDhakad
Copy link
Author

Okay, thanks for making it clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants