Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The calender butttons on community/events page are not rendered properly #3465

Closed
2 tasks done
SahilDahekar opened this issue Dec 12, 2024 · 9 comments · Fixed by #3466
Closed
2 tasks done

[BUG] The calender butttons on community/events page are not rendered properly #3465

SahilDahekar opened this issue Dec 12, 2024 · 9 comments · Fixed by #3466
Labels

Comments

@SahilDahekar
Copy link
Contributor

Describe the bug.

The google calender and ics file button show placeholder instead of actual text.

Expected behavior

The google calender and ics file button should render thier actual text from common.json file.

Screenshots

Screenshot from 2024-12-12 14-12-08

How to Reproduce

  1. Visit /community/events page from navbar.

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@Shubhashish-Chakraborty

Please can i work on this issue!

@derberg @quetzalliwrites

Issue Overview:

The problem occurs on the community/events page, where the button was displaying hardcoded text instead of rendering the actual link text. This impacts the user experience and accuracy of the button functionality.

  • Harcoded Text:
    hardcodedimg

Proposed Solution:

I have identified and thoroughly tested this issue locally. The necessary changes have already been implemented to ensure the button text renders correctly from the appropriate source. I would be delighted to have this task officially assigned to me so I can contribute to resolving this important issue.

Visual Representation, before and after fixes:

asyncapiFix

@Shubhashish-Chakraborty

I’ve implemented a straightforward and effective solution , no additional code files or complex changes required. Just a simple import, and it works seamlessly.

@anshgoyalevil @derberg @quetzalliwrites
I kindly request the maintainers to allow me the opportunity to fix this issue.

@SahilDahekar
Copy link
Contributor Author

I’ve implemented a straightforward and effective solution , no additional code files or complex changes required. Just a simple import, and it works seamlessly.

@anshgoyalevil @derberg @quetzalliwrites I kindly request the maintainers to allow me the opportunity to fix this issue.

Thats Great @Shubhashish-Chakraborty . I assume you have just changed the hard coded values to fix this. Although this is a simple fix, for this issue it is temporary . The root cause is the translation function not working and fetching necessary values from common.json .

Also you can always work on other open issues because this issue already has a PR open.

@Shubhashish-Chakraborty

No sir @SahilDahekar
I've not changed the hardcoded text only..
Actually a better approach...
I have imported the text from the common.json file.
In just a few minutes I'm gonna make a PR.
There you can review.

@Shubhashish-Chakraborty

I’ve implemented a straightforward and effective solution , no additional code files or complex changes required. Just a simple import, and it works seamlessly.

@anshgoyalevil @derberg @quetzalliwrites I kindly request the maintainers to allow me the opportunity to fix this issue.

Thats Great @Shubhashish-Chakraborty . I assume you have just changed the hard coded values to fix this. Although this is a simple fix, for this issue it is temporary . The root cause is the translation function not working and fetching necessary values from common.json .

Also you can always work on other open issues because this issue already has a PR open.

Also i completely understand what youre saying,
Let me raise the PR and fix the code base then you can review on it

@Shubhashish-Chakraborty

This might not be the perfect approach, but I’ve attempted to fix this based on my current understanding. I’m always open to learning and improving, so any feedback or suggestions are greatly appreciated!

@SahilDahekar
Copy link
Contributor Author

@Shubhashish-Chakraborty I just checked your PR . Your approach works as a temporary fix, but it falls short when adding support for multiple languages for the button text. The component loses its dynamic nature since you’d need to update imports each time.

I suggest focusing your time and effort on resolving other issues instead.

@Shubhashish-Chakraborty

Okayy, appreciate it!!

@SyedImtiyaz-1
Copy link

I would like to work on this issue.
If the issue is still ongoing then please assign me this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants