-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] The calender butttons on community/events page are not rendered properly #3465
Comments
Please can i work on this issue!Issue Overview:The problem occurs on the community/events page, where the button was displaying hardcoded text instead of rendering the actual link text. This impacts the user experience and accuracy of the button functionality.Proposed Solution:I have identified and thoroughly tested this issue locally. The necessary changes have already been implemented to ensure the button text renders correctly from the
|
I’ve implemented a straightforward and effective solution , no additional code files or complex changes required. Just a simple import, and it works seamlessly.@anshgoyalevil @derberg @quetzalliwrites |
Thats Great @Shubhashish-Chakraborty . I assume you have just changed the hard coded values to fix this. Although this is a simple fix, for this issue it is temporary . The root cause is the translation function not working and fetching necessary values from Also you can always work on other open issues because this issue already has a PR open. |
No sir @SahilDahekar |
Also i completely understand what youre saying, |
This might not be the perfect approach, but I’ve attempted to fix this based on my current understanding. I’m always open to learning and improving, so any feedback or suggestions are greatly appreciated! |
@Shubhashish-Chakraborty I just checked your PR . Your approach works as a temporary fix, but it falls short when adding support for multiple languages for the button text. The component loses its dynamic nature since you’d need to update imports each time. I suggest focusing your time and effort on resolving other issues instead. |
Okayy, appreciate it!! |
I would like to work on this issue. |
Describe the bug.
The google calender and ics file button show placeholder instead of actual text.
Expected behavior
The google calender and ics file button should render thier actual text from common.json file.
Screenshots
How to Reproduce
🥦 Browser
Google Chrome
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue ?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: