-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Use env variables to load api keys and secrets #2802
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
@maverox where when do have keys currently exposed? |
Algolia keys,
I dont know whether i shoulf tell the exact location here?
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Sambhav Gupta ***@***.***>
Sent: Thursday, March 21, 2024 10:26:01 PM
To: asyncapi/website ***@***.***>
Cc: Uzair Khan ***@***.***>; Mention ***@***.***>
Subject: Re: [asyncapi/website] Feat: Use env variables to load api keys and secrets (Issue #2802)
@maverox<https://github.com/maverox> where when do have keys currently exposed?
—
Reply to this email directly, view it on GitHub<#2802 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHBB34EX44IOUGYIY72D3UTYZMGKDAVCNFSM6AAAAABFBR6LTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGAYDENZVGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
You can DM me on slack |
@maverox I talked to @akshatnema and we came to a conclusion that it is not creating any problem to us so we are not planning to removing it for now |
closing this as not planned for now |
Why do we need this improvement?
Exposed keys are not good for security and integrity, hence it is necessary to have this change
How will this change help?
It will help by securing exposed Api keys and secrets
Screenshots
No response
How could it be implemented/designed?
Yes it can be implemented simply by using .env files and loading the environment variables
🚧 Breaking changes
Yes
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: