-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: footer section orientation for small screens #2742
fix: footer section orientation for small screens #2742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2742--asyncapi-website.netlify.app/ |
@Mayaleeeee @akkshitgupta IMO the current design on website is looking better than this one |
I still prefer the new one though. It's simple and nice to follow. |
@akkshitgupta @Mayaleeeee These are my opinions regarding footer. |
@Mayaleeeee I agree with @akshatnema 's point here |
It's alright, then. cc @akkshitgupta @sambhavgupta0705 |
closing this as not required |
Description
This pull request implements the changes based on the discussion here
Related issue(s) close : #1676