Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should All PRs include a changeset? #992

Closed
KhudaDad414 opened this issue Mar 7, 2024 · 1 comment
Closed

Should All PRs include a changeset? #992

KhudaDad414 opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request stale

Comments

@KhudaDad414
Copy link
Member

Reason/Context

Currently, a PR doesn't need to include any changeset. It means that we can have PR that doesn't trigger a release in any package. it allows maintainers and contributors to include a changeset and select which package they want to bump, and whether it is a breaking change or not.

IMO If something changes in the studio app, it makes sense to release. But there are other packages and the design system. Sometimes change is only made to the docs.

We ignored the release in semantic release by prefixing it with docs, or chore. With changesets, we just don't include any changesets.

Curious to know if there are any alternatives and what problem it cause.

Copy link

github-actions bot commented Jul 6, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Studio - Kanban Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Archived in project
Development

No branches or pull requests

1 participant