Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add princerajpoot20 as code owner for ds and ui #862

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Amzani
Copy link
Collaborator

@Amzani Amzani commented Nov 28, 2023

I suggest @princerajpoot20 as a code owner for the design system apps/design-system/ and ui packages/ui/ as he did major contribution to build the new components, and he is committed to support new studio vision and plans #634.

Some contributions

In addition to committing to this repos he is also reviewing the work of others (e.g #784 / #773)

Copy link

changeset-bot bot commented Nov 28, 2023

⚠️ No Changeset found

Latest commit: 9546382

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 9546382
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/6566382d9b5d0900088f5ae8
😎 Deploy Preview https://deploy-preview-862--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 9546382
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/6566382d79bfdd00085bcaac
😎 Deploy Preview https://deploy-preview-862--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Nov 28, 2023

Absolutely! 👏

@princerajpoot20
Copy link
Member

Thank you so much for proposing me.🙇🏻‍♂️🙇🏻‍♂️ I am fully committed and will give my best. 🙂

Copy link
Member

@princerajpoot20 princerajpoot20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but I guess asyncapi-bot-eve should also be added there.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@princerajpoot20 is right. The bot has to be there, I think.

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas @princerajpoot20 but the @asyncapi-bot-eve is already there with full code ownership. am I missing something? 🤔

btw, welcome aboard @princerajpoot20 ㊗️ 🥳

@princerajpoot20
Copy link
Member

princerajpoot20 commented Nov 29, 2023

@fmvilas @princerajpoot20 but the @asyncapi-bot-eve is already there with full code ownership. am I missing something? 🤔

@KhudaDad414 If the changes are limited to specific areas, such as DS or UI, then only the code owners of those areas are called for review. If the changes include any files outside of these DS/UI segments, then full code owners are also called.

btw, welcome aboard @princerajpoot20 ㊗️ 🥳

Thank you so much! Really happy and grateful to be part of the team 😊🎉

@KhudaDad414
Copy link
Member

@princerajpoot20 the point of asyncapi-bot-eve is to approve bot PRs. not sure if it cares about being called for review. it should approve other bot PRs anyways. 🤔

@fmvilas
Copy link
Member

fmvilas commented Nov 29, 2023

True. It already has full code ownership 👍

@princerajpoot20
Copy link
Member

princerajpoot20 commented Nov 29, 2023

Yes agree, it is there to approve bot PR only.

@Amzani
Copy link
Collaborator Author

Amzani commented Nov 29, 2023

Welcome @princerajpoot20 😊🎉

@Amzani
Copy link
Collaborator Author

Amzani commented Nov 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 789a50d into asyncapi:master Nov 29, 2023
29 checks passed
@fmvilas
Copy link
Member

fmvilas commented Nov 29, 2023

Welcome, @princerajpoot20! 🎉

So now that you're a code owner, you have the right to join the AsyncAPI Technical Steering Committee. If you want to join, please submit a PR updating the MAINTAINERS.yaml. Example: asyncapi/community#801.

@princerajpoot20
Copy link
Member

@fmvilas @Amzani @KhudaDad414

I wanted to say a big thank you🙏. Thank you for trusting me and having faith in me. This means a lot to me. ❤️

I am truly grateful and honored to be part of this awesome community. 🙇‍♂️

Your support means a lot to me. In this journey, I have learned and grown a lot. I will give my best 💯 and do every possible thing I can for the betterment of the Studio and for this community. 🙇‍♂️

@princerajpoot20
Copy link
Member

So now that you're a code owner, you have the right to join the AsyncAPI Technical Steering Committee. If you want to join, please submit a PR updating the MAINTAINERS.yaml.

Definitely, I would love to join TSC, and be a part of this awesome community. 🚀 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants