-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add princerajpoot20 as code owner for ds and ui #862
Conversation
|
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Absolutely! 👏 |
Thank you so much for proposing me.🙇🏻♂️🙇🏻♂️ I am fully committed and will give my best. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but I guess asyncapi-bot-eve
should also be added there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@princerajpoot20 is right. The bot has to be there, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmvilas @princerajpoot20 but the @asyncapi-bot-eve
is already there with full code ownership. am I missing something? 🤔
btw, welcome aboard @princerajpoot20 ㊗️ 🥳
@KhudaDad414 If the changes are
Thank you so much! Really happy and grateful to be part of the team 😊🎉 |
@princerajpoot20 the point of |
True. It already has full code ownership 👍 |
Yes agree, it is there to approve bot PR only. |
Welcome @princerajpoot20 😊🎉 |
/rtm |
Welcome, @princerajpoot20! 🎉 So now that you're a code owner, you have the right to join the AsyncAPI Technical Steering Committee. If you want to join, please submit a PR updating the MAINTAINERS.yaml. Example: asyncapi/community#801. |
I wanted to say a big thank you🙏. Thank you for trusting me and having faith in me. This means a lot to me. ❤️ I am truly grateful and honored to be part of this awesome community. 🙇♂️ Your support means a lot to me. In this journey, I have learned and grown a lot. I will give my best 💯 and do every possible thing I can for the betterment of the Studio and for this community. 🙇♂️ |
Definitely, I would love to join TSC, and be a part of this awesome community. 🚀 ❤️ |
I suggest @princerajpoot20 as a code owner for the design system
apps/design-system/
and uipackages/ui/
as he did major contribution to build the new components, and he is committed to support new studio vision and plans #634.Some contributions
In addition to committing to this repos he is also reviewing the work of others (e.g #784 / #773)