feat: add error toasts when loading from "url" query paramater #622
Conversation
ppfenning92
requested review from
fmvilas,
boyney123,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
ppfenning92
changed the title
|
@magicmatatjahu would you mind having a look, please? |
|
cc @KhudaDad414 |
There was a problem hiding this comment.
@ppfenning92 it works great if the url is broken. can you also cover the case when the url returns 404 error? like this one: https://raw.githubusercontent.com/asyncapi/spec-json-schemas/ff3ab77b5bbad0ff05eabc4b10c8685638dcc4a7/examples/2.6.0/componnts.json
|
@KhudaDad414 sure, give me some time, very busy these days.... |
|
@ppfenning92 sure man. just let me know when it is ready for review. |
|
@ppfenning92 could you fix the conflicts |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
screenshot for clarity :) |
|
@KhudaDad414 can you have a look here? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
Description
urlquery paramater fails