Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding onboarding documentation to studio #396

Closed
wants to merge 3 commits into from
Closed

feat: adding onboarding documentation to studio #396

wants to merge 3 commits into from

Conversation

yashsehgal
Copy link

@yashsehgal yashsehgal commented Jul 26, 2022

Description

This PR contains the implementation of the Onboarding Documentation Feature. Referring #284

  • Creating a modal for showing documentation for onboarding
  • Adding swiping/sliding functionalities to all the slides for better UX
  • Creating the component customizable with JSON files

Related issue(s)

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 9d47344
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/62fb2e547395c70009c8585e
😎 Deploy Preview https://deploy-preview-396--modest-rosalind-098b67.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@yashsehgal yashsehgal changed the title Adding Onboarding Documentation to Studio feat: Adding Onboarding Documentation to Studio Jul 28, 2022
@yashsehgal yashsehgal changed the title feat: Adding Onboarding Documentation to Studio feat: adding onboarding documentation to studio Jul 28, 2022
@mcturco
Copy link
Member

mcturco commented Jul 29, 2022

@yashsehgal Should we convert this PR to a draft for now? I think there is still some work to be done from a content and visual perspective, and as I see the modal is not quite working atm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yashsehgal
Copy link
Author

@yashsehgal Should we convert this PR to a draft for now? I think there is still some work to be done from a content and visual perspective, and as I see the modal is not quite working atm

I was thinking about the same thing sometime before. Yeah sure, we can me it a draft PR and focus of the visual perspectives first. 👍🏽

@magicmatatjahu
Copy link
Member

@yashsehgal Hi! Do you need some help there? :)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Dec 22, 2022
@magicmatatjahu
Copy link
Member

@yashsehgal Do you have a time to work on it?

@github-actions github-actions bot removed the stale label Dec 23, 2022
@fmvilas
Copy link
Member

fmvilas commented Dec 23, 2022

Since Studio is still in beta, I would hold this one. We're likely gonna change it a lot in the upcoming months, most probably breaking the onboarding. I think a good time to do it would be once we have a release candidate for version 1.0.0.

@github-actions github-actions bot added the stale label Apr 23, 2023
@github-actions github-actions bot removed the stale label May 11, 2023
@github-actions github-actions bot added the stale label Sep 9, 2023
@KhudaDad414 KhudaDad414 removed the stale label Sep 26, 2023
@asyncapi asyncapi deleted a comment from github-actions bot Sep 26, 2023
@asyncapi asyncapi deleted a comment from github-actions bot Sep 26, 2023
@KhudaDad414 KhudaDad414 marked this pull request as draft September 26, 2023 08:42
@KhudaDad414
Copy link
Member

This PR has been marked as draft so we can ignore it for now till we have the 1.0 version ready.

@yashsehgal yashsehgal closed this by deleting the head repository Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants