Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish AsyncAPI Studio Docker image with additional version tag #1150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Oct 23, 2024

Description

This PR extends the Docker publishing workflow so that an additonal version tag is published to Docker Hub. This already happened before the migration from semantic-release to changesets. I think it's desirable to bring it back because there are only super outdated versions on Docker Hub right now: https://hub.docker.com/r/asyncapi/studio/tags.

Related issue(s)

Let me know if I should create one.

⚒️ with ❤️ by Siemens

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 854e072

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/studio Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for studio-next failed.

Name Link
🔨 Latest commit e9ab74d
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/6718a8c008b252000845656c

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for modest-rosalind-098b67 failed.

Name Link
🔨 Latest commit 854e072
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/673c99ee4d559e000889b874

@@ -17,10 +17,18 @@ jobs:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Get current Studio version
id: get-studio-version
uses: martinbeentjes/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +32 to +34
asyncapi/studio:latest
asyncapi/studio:${{ steps.get-studio-version.outputs.current-version}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 854e072
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/673c99ee4d559e000889b876
😎 Deploy Preview https://deploy-preview-1150--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fgreinacher
Copy link
Contributor Author

/ptal

@asyncapi-bot
Copy link
Contributor

@Amzani @magicmatatjahu @KhudaDad414 @Shurtu-gal Please take a look at this PR. Thanks! 👋

@fgreinacher
Copy link
Contributor Author

/ptal

Let me know what I can do to make your review easier 🙇

@asyncapi-bot
Copy link
Contributor

@Amzani @magicmatatjahu @KhudaDad414 @Shurtu-gal Please take a look at this PR. Thanks! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants