fix: Enhancement of Visual Json Schema Editor #1065
Conversation
…ses which path contain `array<object>`
Gmin2
requested review from
KhudaDad414,
Amzani and
princerajpoot20
as code owners
|
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @princerajpoot20 it is done and ready for review cc @Amzani |
There was a problem hiding this comment.
Good work @utnim2 .
Have you tested this with all the sample JSON schemas?
- There is no option to
add propertyto thearray<object>type. - In the UI for array properties, we should not have
Array Itemsas text. - If we are changing the type of an existing property, when I change it to type array of string, it directly assigns the same value. For example:
"type": "array<string>".
Instead, it should be like
"type": "array",
"items": {
"type": "number"
}
Could you make the code editor text be beautify after performing any operation
… removed "Array Items", fixed changing of type for array types
|
Done all the reviewed changes @princerajpoot20
could you explain this more what exactly do you want, ig i have matched the design provided |
@utnim2 After modification, the JSON schema is not in a readable form.
After having array , in next line we again mention object. 
This text is there if root is of type array 
This text can be removed |
netlify is not rendering the latest commits, you can use github cli and then see the changes |
|
It is not that Netlify has not rendered your latest commit. It automatically takes your latest commit. Their problem is something else. 
If the changes are not visible in the PR preview, then they will not be visible in deployment (after merge) either. |
it is working fine in my machine, idk why netlify is parsing it as a string rather then schemaObject |
|
Hey @princerajpoot20 in the deploy preview also it is showing right
|
|
@Gmin2 I'm talking about editor after making changes through visual editor. screen.recording.mov |
|
@princerajpoot20 is that necessary? we will have something nicer like a Codemirror editor and an easy-to- edit format like YAML over there anyway. |
@KhudaDad414 Sure, this sounds good. |
This reverts commit 2be5cb0.
|
@princerajpoot20 pingy pongy. |
|
|
/rtm |
Description
Related issue(s)
Resolves Enhance the Visual JSON Schema Editor #1023