feat: Use Next.js in studio-next #1062
Conversation
KhudaDad414
requested review from
magicmatatjahu,
Amzani and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 68a61e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@KhudaDad414 Besides this PR, is anything else required to have Studio working on Next-JS ? I mean, If we merge this "today", will everything work out of the box? |
|
@smoya Yes, it should work as expected. |
I hope this gets merged soon 🤞 |
| @@ -9,25 +9,80 @@ | |||
| "lint": "next lint" | |||
| }, | |||
| "dependencies": { | |||
| "@codemirror/state": "^6.4.1", | |||
There was a problem hiding this comment.
@KhudaDad414 why codemirror is revered. It was added by @Shurtu-gal in #997
There was a problem hiding this comment.
I don't think it's a great idea to push for the CodeMirror at this stage. Migrating to CodeMirror would make the task much much more challenging and this task is already huge.
The CodeMirror was added as a separate code editor and it wasn't configured with the codebase in any shape or form. I imagine integrating a new code editor with our codebase would also be challenging.
here is what I am suggesting: the code is there in the history, let's go ahead with Monaco we can swap the code editor as part of the bounty issue.
TLDR; migration is already complicated enough let's switch to CodeMirror after we migrate to NEXT.
|
Looks like we don't have the logo, do you reproduce as well ? |
|
@Amzani it show up as expected now. |
|
At a quick glance, I found some differences between versions. The height of the app is not adjusted in the deploy preview. The Settings button is hidden unless you scroll down (at least in my native MacBook resolution). Same happens with the "errors" and "warnings" bar. Current production version (https://studio.asyncapi.com): This new version (https://deploy-preview-1062--studio-next.netlify.app/):
The tooltips on the navigation bar differ from one version an the other: Current production version (https://studio.asyncapi.com): This new version (https://deploy-preview-1062--studio-next.netlify.app/): Additionally, font size or space differs from one version to the other:
|
|
@smoya thanks for the review. 🙇 I can replicate the issues. will make the appropriate changes. |
Nooice! BTW didnt test all functionalities, but just checked the appeal of the page. Meaning it could have more issues (or not). |
|
@smoya done. please take a look when you have the time. |
|
|
/rtm |
Description
Some known issues and possible improvements:
fixes #684