Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Og image Url modification #1009

Closed
wants to merge 11 commits into from
Closed

Conversation

tihom4537
Copy link

Description

  • ...
  • ...
  • ...

Related issue(s)

Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: a608c53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit a608c53
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65f580d1c4f86900083ed1a3
😎 Deploy Preview https://deploy-preview-1009--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit a608c53
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65f580d1c96b250008aa2a05
😎 Deploy Preview https://deploy-preview-1009--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit a608c53
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/65f580d1b7efa500087dd3b7
😎 Deploy Preview https://deploy-preview-1009--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Amzani
Copy link
Collaborator

Amzani commented Mar 14, 2024

@tihom4537 could you please reference the issue your are solving in this PR?
Thanks

<meta property="og:type" content="website">
<meta property="og:url" content="https://studio.asyncapi.com/">
<meta property="og:url" content="https://jovial-jalebi-77dbf2.netlify.app">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for changing this URL?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Amzani
Copy link
Collaborator

Amzani commented Mar 18, 2024

@tihom4537 closing this as I didn't get any answer from you.
Feel free to create an issue first and discuss this change.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants