Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix header format in gitter example #965

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

lornajane
Copy link
Contributor


title: "Gitter example: fix header format"


Related issue(s):


I noticed (when working on tooling for AsyncAPI) that the Gitter example we have doesn't follow the HTTP Message Bindings format - but it almost does, so I fixed it :)

No spec changes, just an update to an example file

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

examples/gitter-streaming.yml Outdated Show resolved Hide resolved
@lornajane lornajane requested a review from fmvilas September 5, 2023 07:42
@lornajane lornajane changed the title Gitter example: fix header format chore: fix header format in gitter example Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Sep 6, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 10ffb46 into asyncapi:master Sep 6, 2023
8 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants