Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify expected type for Message headers #952

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Jul 13, 2023

Comes from #948 (comment)

This PR clarifies the expected type and shape for Message headers.

@smoya smoya changed the title Fix: clarify expected type for Message headers fix: clarify expected type for Message headers Jul 13, 2023
@smoya
Copy link
Member Author

smoya commented Jul 19, 2023

@fmvilas would you mind taking a look to this? 🙏

@derberg
Copy link
Member

derberg commented Jul 20, 2023

please do not merge before #939 as release is somehow broken and RC for traits for example was not out

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya
Copy link
Member Author

smoya commented Jul 28, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit e2a3fa4 into asyncapi:next-major-spec Jul 28, 2023
@smoya smoya deleted the fix/headersType branch July 28, 2023 09:29
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants