-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where to put JMS specific headers? #919
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
@adamretter in AsyncAPI all protocol-specific semantics are delegated to AsyncAPI bindings. You can also have Message level bindings. The problem is just that nobody yet from there was some enquiry in the past asyncapi/bindings#87 but did not go too far. does that help? |
@derberg That is helpful thanks. So I guess we should put things in the JMS Message Binding object of our Async API Schema. We are not experts in JMS, but we can try and help; would you be happy to receive a PR against https://github.com/asyncapi/bindings/tree/master/jms from us? |
Yes please!!! it is hard to find someone to do first step. You might not be experts but doing first step will enable us to share your PR with rest of the community to drag them in with feedback. Thanks 🙏 Once you open up a PR we will close this issue. For now leaving it open to have it as reminder |
Thanks @derberg I have sent a PR for a set of JMS Object bindings to here - asyncapi/bindings#193 |
The documentation for version 2.6.0 of the AsyncAPI spec seems to contradict itself regards protocol specific headers for JMS.
It says here: https://www.asyncapi.com/docs/reference/specification/v2.6.0#messageObject
However, if I follow the documentation through:
Message
object may have atraits
property.Message Trait
object may have abindings
propertyMessage Bindings
object may have ajms
property.JMS Message Binding
object does not permit any properties.If I cannot put the protocol specific headers in the Message or Message Trait, and if I can't put them in the JMS Message Binding... where can I put them?
The text was updated successfully, but these errors were encountered: