Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to put JMS specific headers? #919

Closed
adamretter opened this issue Apr 3, 2023 · 5 comments · Fixed by asyncapi/bindings#193
Closed

Where to put JMS specific headers? #919

adamretter opened this issue Apr 3, 2023 · 5 comments · Fixed by asyncapi/bindings#193
Labels
❔ Question A question about the spec or processes

Comments

@adamretter
Copy link

The documentation for version 2.6.0 of the AsyncAPI spec seems to contradict itself regards protocol specific headers for JMS.

It says here: https://www.asyncapi.com/docs/reference/specification/v2.6.0#messageObject

Schema definition of the application headers. Schema MUST be of type "object". It MUST NOT define the protocol headers.

However, if I follow the documentation through:

  1. A Message object may have a traits property.
  2. A Message Trait object may have a bindings property
  3. A Message Bindings object may have a
    jms property.
  4. The JMS Message Binding object does not permit any properties.

If I cannot put the protocol specific headers in the Message or Message Trait, and if I can't put them in the JMS Message Binding... where can I put them?

@adamretter adamretter added the ❔ Question A question about the spec or processes label Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Apr 3, 2023

@adamretter in AsyncAPI all protocol-specific semantics are delegated to AsyncAPI bindings. You can also have Message level bindings. The problem is just that nobody yet from JMS community took time to contribute what these should be and volunteer to maintain it in future.

there was some enquiry in the past asyncapi/bindings#87 but did not go too far.

does that help?

@adamretter
Copy link
Author

@derberg That is helpful thanks. So I guess we should put things in the JMS Message Binding object of our Async API Schema.

We are not experts in JMS, but we can try and help; would you be happy to receive a PR against https://github.com/asyncapi/bindings/tree/master/jms from us?

Copy link
Member

derberg commented Apr 3, 2023

Yes please!!! it is hard to find someone to do first step. You might not be experts but doing first step will enable us to share your PR with rest of the community to drag them in with feedback. Thanks 🙏

Once you open up a PR we will close this issue. For now leaving it open to have it as reminder

@adamretter
Copy link
Author

adamretter commented Apr 3, 2023

Thanks @derberg I have sent a PR for a set of JMS Object bindings to here - asyncapi/bindings#193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ Question A question about the spec or processes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants