Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to extend CODEOWNERS with new contributor #720

Closed
derberg opened this issue Feb 10, 2022 · 5 comments · Fixed by #723 or asyncapi/spec-json-schemas#173
Closed

Suggestion to extend CODEOWNERS with new contributor #720

derberg opened this issue Feb 10, 2022 · 5 comments · Fixed by #723 or asyncapi/spec-json-schemas#173

Comments

@derberg
Copy link
Member

derberg commented Feb 10, 2022

@fmvilas I'd like to propose we extend list of codeowners for the specification and the json schema repo. I hope @dalelane agrees 🙏🏼

@dalelane, even though affiliated with IBM, demonstrated several times that he is a great community member and helped in many specification-related works that were not directly beneficial only to IBM. What I mean is that from my perspective Dale demonstrated he can be trusted to help in spec maintenance for the good of the community and not the company he works for:

Technically speaking, @fmvilas I'd love to have Dale as codeowner:

@dalelane I hope you accept 🙏🏼 I personally would be honored 🍺

P.S. I summarized your achievements for the first time while writing this issue. I have to say you raised a bar for new potential code owners pretty high 😆 and I bet I did not mention all topics

@fmvilas
Copy link
Member

fmvilas commented Feb 10, 2022

Huge YES from my side ♥️🙌🎉

@dalelane
Copy link
Collaborator

That's very kind, I'd love to - thank you!

@fmvilas
Copy link
Member

fmvilas commented Feb 14, 2022

PRs created ☝️

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.1-2022-04-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants