-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invite Heiko Henning to join as code owner #1008
Comments
Thanks for this honor. I am happily accepted the nomination. |
Yes Yes Yes!🙌 |
Sounds good to me 🚀 Through request/reply work I'm sure @GreenRover learned a lot on how things work here and how the process of adding features looks like, and how important it is to accommodate different use cases. |
Of course yes, we all remember request/reply exceptional work ;) |
@dalelane I think your vote is the only one missing here 🙏 I see you have a 👍 in the issue description but I believe better to be explicit in a comment if you don't mind. |
sorry - yes, happy to support this |
@GreenRover if you are still into this, do you want to create a PR adding your user to the
|
I think parser shouldn't be included. Just spec, spec-json-schemas, and bindings. |
The PRs are created:
@fmvilas I try to earn me code ownership for parser-js may be later. I guess there are enough open todos. |
Yeah, don't get me wrong, I don't know if you deserve to be a code maintainer of the parser or not. I just wanted to clarify that becoming a code owner of the spec gives you the right to become code owner of bindings and spec-json-schemas but not other stuff. Or at least that's what I remember we discussed 😄 |
I recently announced it in Slack. @thulieblack will schedule a Tweet for ~tomorrow. (Thanks!) Closing the issue |
I'd like to invite @GreenRover to join the spec (and related repos: bindings, spec-json-schemas) as a code owner. Heiko has been contributing for a while now and he has contributed one of the coolest (if not the coolest) features of AsyncAPI 3.0.0, i.e., request/reply support.
That said, I haven't checked with Heiko beforehand so he would have to agree first, of course 😄
@derberg @smoya @dalelane @char0n
The text was updated successfully, but these errors were encountered: