-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: operation trait object description #1001
docs: operation trait object description #1001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
hey @akshatnema @smoya it would be great id you review the pull request for any changes or anything |
I would recommend you do it better in a new PR |
sure @smoya I will raise a new PR by improving the MarkDown linting as per the standards once this gets merged to avoid any conflicts |
@akshatnema please change the title prefix to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will every PR has such a good and clear description, showing state before and after applying PR. Such a speed up for maintainer to do a review ❤️
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
/rtm |
@all-contributors please add @akkshitgupta for content,doc |
I've put up a pull request to add @akkshitgupta! 🎉 |
title: "FIX: operation trait object description"
Related issue(s): fixes: #994
messages
field asoperation trait object
doesn't havemessages
field likeaction
orchannel
.messages
field as well along with others.Add the ✏️ Editorial label.
NOTE: I found a number of MarkDown linting errors. Just want to confirm is it fine to Push the refactored changes in the same Pull Request or open a New Pull Request.