Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce cognitive complexity in validate-schemas.js #482

Closed
AnimeshKumar923 opened this issue Jan 10, 2024 · 10 comments · Fixed by #483
Closed

Reduce cognitive complexity in validate-schemas.js #482

AnimeshKumar923 opened this issue Jan 10, 2024 · 10 comments · Fixed by #483
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers released

Comments

@AnimeshKumar923
Copy link
Contributor

@github-actions GitHub Actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Gmin2
Copy link
Contributor

Gmin2 commented Jan 10, 2024

@AnimeshKumar923 i am taking this up.Is it okay or you are working in it?

@AnimeshKumar923
Copy link
Contributor Author

@Min2who yes it's okay, feel free to work upon it. 👍

@AnimeshKumar923
Copy link
Contributor Author

/help

@asyncapi-bot
Copy link
Contributor

Hello, @AnimeshKumar923! 👋🏼

I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

@AnimeshKumar923
Copy link
Contributor Author

/enhancement

@AnimeshKumar923
Copy link
Contributor Author

/gfi js

@asyncapi-bot asyncapi-bot added area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Jan 12, 2024
This was referenced Jan 12, 2024
Merged
Merged
@AnimeshKumar923
Copy link
Contributor Author

Any updates? @Min2who

@Gmin2
Copy link
Contributor

Gmin2 commented Jan 25, 2024

@AnimeshKumar923 i have added the changes that you have mentioned.
please review the pr

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reduced the complexity of validate-schema.js
3 participants
@asyncapi-bot @AnimeshKumar923 @Gmin2