feat: update to parser API v3 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
derberg,
magicmatatjahu,
fmvilas and
asyncapi-bot-eve
as code owners
derberg
reviewed
Nov 20, 2023
|
This PR is blocked by asyncapi/cli#908 |
|
@jonaslagoni Can we merge this PR as asyncapi/cli/908 is merged now. |
fmvilas
approved these changes
Nov 29, 2023
fmvilas
requested changes
Nov 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
fmvilas
approved these changes
Nov 29, 2023
|
/rtm |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Pretty sure this should have been a breaking change 🤔 Or is this fine? @fmvilas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the parser API to v3 and removes messageId usage. It also fixes dependency shift.
Related issue(s)
Fixes #385
Blocked by asyncapi/generator#1066
Blocked by asyncapi/cli#908