Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AsyncAPI v3.0.0 no longer serializable #198

Closed
2 tasks done
ChMThiel opened this issue May 6, 2024 · 9 comments
Closed
2 tasks done

[BUG] AsyncAPI v3.0.0 no longer serializable #198

ChMThiel opened this issue May 6, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@ChMThiel
Copy link

ChMThiel commented May 6, 2024

Describe the bug.

Im trying to upgrade the AsyncApi Quarkus-Plugin to AsyncAPI v3.

In V2 of com.asyncapi.v2._0_0.model.AsyncAPI, the field asysncapi was not final:
grafik
in V3 it's final (com.asyncapi.v3._0_0.model.AsyncAPI):
grafik
This prevents the object to be serialized/deserialized in my Quarkus-Extension:

Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Cannot serialise field 'asyncapi' on object 
AsyncAPI(asyncapi=3.0.0,
...
 as the property is read only

Expected behavior

AsyncAPI in V3 is de/serializable to by Quarkus' ByteRecorder

Screenshots

see above

How to Reproduce

see https://github.com/quarkiverse/quarkus-asyncapi/tree/asyncApi_v3

🥦 Browser

Mozilla Firefox

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it

@ChMThiel ChMThiel added the bug Something isn't working label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Pakisan Pakisan self-assigned this May 6, 2024
@Pakisan
Copy link
Member

Pakisan commented May 7, 2024

@ChMThiel Hi!

Will change it today. Please, switch to /release/1.0.0-RC2

This release will introduce breaking changes:

  • bindings in own packages
  • schemas in own package

@ChMThiel
Copy link
Author

ChMThiel commented May 8, 2024

@Pakisan Thank you very much for the quick reply!
Are there any plans when the release 1.0.0 will be available?

@Pakisan
Copy link
Member

Pakisan commented May 8, 2024

@Pakisan Thank you very much for the quick reply!

Are there any plans when the release 1.0.0 will be available?

I'm not sure when exactly I'll release 1.0.0

I want to add new bindings versions and left it for a while(few months I think), to

  1. Collect feedback from users
  2. Add v3 support to apicurio
  3. Add my tests to our json schemas and TCK repos

@Pakisan
Copy link
Member

Pakisan commented May 11, 2024

@ChMThiel I removed final from AsyncAPI.asyncapi field

@ChMThiel
Copy link
Author

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

@Pakisan
Copy link
Member

Pakisan commented May 14, 2024

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Check updated release branch. If everything is working as expected, I'll publish it May 16/17(waiting for response from other folks)

@ChMThiel
Copy link
Author

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Check updated release branch. If everything is working as expected, I'll publish it May 16/17(waiting for response from other folks)

@Pakisan @fjtirado I checked the current 1.0.0-RC2 localy. Everything works, all i had to do is to adjust some imports...
looking forward to the release...

@Pakisan
Copy link
Member

Pakisan commented May 16, 2024

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Check updated release branch. If everything is working as expected, I'll publish it May 16/17(waiting for response from other folks)

@Pakisan @fjtirado I checked the current 1.0.0-RC2 localy. Everything works, all i had to do is to adjust some imports... looking forward to the release...

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants