Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2.6.0 #104

Merged
merged 16 commits into from
Sep 3, 2024
Merged

feat: 2.6.0 #104

merged 16 commits into from
Sep 3, 2024

Conversation

Pakisan
Copy link
Member

@Pakisan Pakisan commented Aug 27, 2024

Added

  • IDEA 2024.2
  • Yaml single quoted references handling - '#/components/messages/welcomeMessage'
  • .yml file recognition

Closes #99
Closes asyncapi/jasyncapi#204
Closes #101
Closes #48
Closes #47
Closes #35
Closes #31

@Pakisan Pakisan changed the title release: 2.6.0 feat: 2.6.0 Aug 28, 2024
Pakisan and others added 2 commits August 29, 2024 00:12
@Pakisan Pakisan marked this pull request as ready for review August 28, 2024 20:27
@Pakisan
Copy link
Member Author

Pakisan commented Aug 28, 2024

@philCryoport it's review time 😅

Copy link
Member

@theschles theschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pakisan See questions below.

FYI the index.js file apparently is so big that I can't open it in Sublime Text without hanging my computer

.idea/kotlinc.xml Show resolved Hide resolved
.idea/misc.xml Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
src/main/resources/META-INF/plugin.xml Show resolved Hide resolved
Our developers believe that you likely built the plugin against version 2024.2, which includes a companion object in this class. As a result, the generated bytecode references it. To ensure compatibility, the plugin should be built against the lowest supported version, which in this case is 2022.3.

Please adjust the IntelliJ version to 2022.3 in the Gradle build script and try building the plugin again.
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link
Collaborator

@philCryoport philCryoport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully these will do the trick.
//MUST NOT be changed. Oy 🤦‍♂️

Copy link
Member

@theschles theschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided my thoughts as @philCryoport

@Pakisan Pakisan merged commit 21ffe88 into master Sep 3, 2024
9 checks passed
@Pakisan Pakisan deleted the release/2.6.0 branch September 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants