-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 2.5.0 #55
build: 2.5.0 #55
Conversation
v2: - 2.0.0 - 2.1.0 - 2.2.0 - 2.3.0 - 2.4.0 - 2.5.0 - 2.6.0 v3: - 3.0.0 asyncapi/spec-json-schemas#494 #49
2023.3.2 2023.3.3 2023.3.4 2023.3.5
Hi @Pakisan just saw this. Will look at it when I get into the office later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you verify your JSON changes didn't break anything?
For record's sake, I ran
Ahem...then decided to RTFM Screen output from `./gradlew check`
Here's the full output |
Quality Gate passedIssues Measures |
Now:
In future: |
This is fine😓 This is so old, that I'm resigned with it. Those tests are checking single scenario - At runtime everything is working great, but in test context it fails. I think that will fix it in parallel with #47, cause it's about digging into JetBrains sdk to fix it |
Issue created #59 |
Issue created #60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted various improvements in issues.
@theschles is my personal Github; @philCryoport is my work account. |
Added
Fixed
Changed
^x-[\w\d\-\_]+$
was changed to^x-[\w\d\.\x2d_]+$
schemaFormat
to messages to recognize properly non AsyncAPI SchemasJsonSchema
Draft 07schemaFormat
to messages to recognize properly non AsyncAPI SchemasJsonSchema
Draft 07schemaFormat
to messages to recognize properly non AsyncAPI SchemasJsonSchema
Draft 07schemaFormat
to messages to recognize properly non AsyncAPI SchemasJsonSchema
Draft 07schemaFormat
to messages to recognize properly non AsyncAPI SchemasJsonSchema
Draft 07schemaFormat
to messages to recognize properly non AsyncAPI SchemasJsonSchema
Draft 07