Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 2.5.0 #55

Merged
merged 13 commits into from
Apr 22, 2024
Merged

build: 2.5.0 #55

merged 13 commits into from
Apr 22, 2024

Conversation

Pakisan
Copy link
Member

@Pakisan Pakisan commented Apr 10, 2024

Added

  • IDEA 2024.1

Fixed

  • Incorrect validation of Multi Format Schema and bindings

Changed

  • 2.0.0 schema validation and completion:
    • Updated allowed extension name: ^x-[\w\d\-\_]+$ was changed to ^x-[\w\d\.\x2d_]+$
    • OpenAPI schema v3
    • Added schemaFormat to messages to recognize properly non AsyncAPI Schemas
    • Was updated JsonSchema Draft 07
  • 2.1.0 schema validation and completion:
    • OpenAPI schema v3
    • Added schemaFormat to messages to recognize properly non AsyncAPI Schemas
    • Was updated JsonSchema Draft 07
  • 2.2.0 schema validation and completion:
    • OpenAPI schema v3
    • Added schemaFormat to messages to recognize properly non AsyncAPI Schemas
    • Was updated JsonSchema Draft 07
  • 2.3.0 schema validation and completion:
    • OpenAPI schema v3
    • Added schemaFormat to messages to recognize properly non AsyncAPI Schemas
    • Was updated JsonSchema Draft 07
  • 2.4.0 schema validation and completion:
    • OpenAPI schema v3
    • Added schemaFormat to messages to recognize properly non AsyncAPI Schemas
    • Was updated JsonSchema Draft 07
  • 2.5.0 schema validation and completion:
    • OpenAPI schema v3
    • Added schemaFormat to messages to recognize properly non AsyncAPI Schemas
    • Was updated JsonSchema Draft 07
  • 3.0.0 schema validation and completion:
    • Bindings:
      • Solace:
        • server binding 0.4.0
        • operation binding 0.4.0
      • HTTP:
        • message binding 0.3.0
        • operation binding 0.3.0

@theschles
Copy link
Member

Hi @Pakisan just saw this. Will look at it when I get into the office later today.

Copy link
Collaborator

@philCryoport philCryoport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you verify your JSON changes didn't break anything?

gradle/wrapper/gradle-wrapper.properties Show resolved Hide resolved
@philCryoport
Copy link
Collaborator

philCryoport commented Apr 19, 2024

For record's sake, I ran :runPluginVerifier. Result:

BUILD SUCCESSFUL in 11m 3s
17 actionable tasks: 8 executed, 9 up-to-date

Ahem...then decided to RTFM ./gradlew...

Screen output from `./gradlew check`
jasyncapi-idea-plugin on  release/2.5.0 is 📦 2.5.0+jre17 via ☕ v21.0.2 via 🅒 base
➜ ./gradlew :check

> Task :verifyPluginConfiguration
[gradle-intellij-plugin :verifyPluginConfiguration] The following plugin configuration issues were found:
- The 'since-build' property is lower than the target IntelliJ Platform major version: 223 < 241.
- The dependency on the Kotlin Standard Library (stdlib) is automatically added when using the Gradle Kotlin plugin and may conflict with the version provided with the IntelliJ Platform, see: https://jb.gg/intellij-platform-kotlin-stdlib
See: https://jb.gg/intellij-platform-versions

> Task :test
CompileCommand: exclude com/intellij/openapi/vfs/impl/FilePartNodeRoot.trieDescend bool exclude = true

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:162

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:162

JsonReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at JsonReferenceVariantsTest.kt:161

YamlReferenceVariantsTest > test referenced file FAILED
    junit.framework.AssertionFailedError at YamlReferenceVariantsTest.kt:160

431 tests completed, 16 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///foo/asyncapi/jasyncapi-idea-plugin/build/reports/tests/test/index.html

* Try:
> Run with --scan to get full insights.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.6/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 31s
14 actionable tasks: 8 executed, 6 up-to-date

Here's the full output
test.zip

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Pakisan
Copy link
Member Author

Pakisan commented Apr 20, 2024

How did you verify your JSON changes didn't break anything?

Now:

  • I have repo with bunch of different specifications, where I test bundled JsonSchema for correctness
  • Tests inside project to validate correctness of auto-completion which is relaying on JsonSchema

In future:
On May, I hope, I'll reanimate our TCK repo to switch to it for schema tests

@Pakisan
Copy link
Member Author

Pakisan commented Apr 20, 2024

For record's sake, I ran :runPluginVerifier. Result:

BUILD SUCCESSFUL in 11m 3s
17 actionable tasks: 8 executed, 9 up-to-date

Ahem...then decided to RTFM ./gradlew...

Screen output from ./gradlew check
Here's the full output test.zip

This is fine😓

This is so old, that I'm resigned with it. Those tests are checking single scenario - $ref to external file.

At runtime everything is working great, but in test context it fails.

I think that will fix it in parallel with #47, cause it's about digging into JetBrains sdk to fix it

@philCryoport
Copy link
Collaborator

For record's sake, I ran :runPluginVerifier. Result:

BUILD SUCCESSFUL in 11m 3s
17 actionable tasks: 8 executed, 9 up-to-date

Ahem...then decided to RTFM ./gradlew...
Screen output from ./gradlew check
Here's the full output test.zip

This is fine😓

This is so old, that I'm resigned with it. Those tests are checking single scenario - $ref to external file.

At runtime everything is working great, but in test context it fails.

I think that will fix it in parallel with #47, cause it's about digging into JetBrains sdk to fix it

Issue created #59

@philCryoport
Copy link
Collaborator

How did you verify your JSON changes didn't break anything?

Now:

* I have repo with bunch of different specifications, where I test bundled JsonSchema for correctness

* Tests inside project to validate correctness of auto-completion which is relaying on JsonSchema

In future: On May, I hope, I'll reanimate our TCK repo to switch to it for schema tests

Issue created #60

Copy link
Collaborator

@philCryoport philCryoport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted various improvements in issues.

@theschles
Copy link
Member

@theschles is my personal Github; @philCryoport is my work account.

@Pakisan Pakisan merged commit c0c0f1a into master Apr 22, 2024
8 checks passed
@Pakisan Pakisan deleted the release/2.5.0 branch April 22, 2024 20:33
@Pakisan Pakisan restored the release/2.5.0 branch April 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants