Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for urgent changes in GitHub Actions automation #29

Closed
derberg opened this issue May 30, 2023 · 8 comments
Closed

Need for urgent changes in GitHub Actions automation #29

derberg opened this issue May 30, 2023 · 8 comments
Assignees

Comments

@derberg
Copy link
Member

derberg commented May 30, 2023

This issue defines a list of tasks that need to be performed in this repo to make sure it's ci/cd automation works long term without any issues.

It is up to maintainers to decide if it must be addressed in one or multiple PRs.

Below are 3 different sections describing 3 different important ci/cd changes.

IMPORTANT-START
For GitHub workflows that contain This workflow is centrally managed in https://github.com/asyncapi/.github/ you do not have to perform any work. These workflows were already updated through the update in .github. The only exception is the workflows related to nodejs release. More details in Upgrade Release pipeline - in case of nodejs projects section
IMPORTANT-END

Deprecation of way data is shared between steps

Every single GitHub Action workflow that has echo "::set-output name={name}::{value}" need to be updated to follow echo "{name}={value}" >> $GITHUB_OUTPUT

We do not yet know when set-output will stop working. Previous disable date was 31.05 but now then say community needs more time.

For more details read official article from GitHub

Deprecation of node12

2nd bullet point is still relevant for you even if your projects in not nodejs project

  • Every single workflow that uses setup-node action needs an update to follow v3 version of this action, and make sure minimum node 14 is used
  • Now this part is more complex. Problem with node12 is that node-based GitHub Actions were using it in majority as a runtime environment. Look for example at this action.yaml file for setup-node action v2. So the job that you have to do is go through all the workflows, and verify every single action that you use, make sure you are using the latest version that is not based on node12. I already did review a lot of actions as part of this PR so maybe you will find some actions there and can copy from me. For example action/checkout needs to be updated to v3.

Node12 end of support in action is probably September 27th.

For more details read official article from GitHub

Upgrade Release pipeline - in case of nodejs projects

ignore this section if your project is not nodejs project

You have 2 options. You can:

A. choose to switch to new release pipeline using instruction from asyncapi/.github#205

B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR asyncapi/.github#226

I definitely recommend going with A

Workflows related to release:

  • .github/workflows/if-nodejs-release.yml
  • .github/workflows/if-nodejs-version-bump.yml
  • .github/workflows/bump.yml
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@theschles
Copy link
Member

Hi @Pakisan which way do you suggest?

Do you want to go with "A. choose to switch to new release pipeline using instruction from asyncapi/.github#205"?

or "B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR asyncapi/.github#226"

@Pakisan
Copy link
Member

Pakisan commented Jun 8, 2023

@theschles @derberg

Will check on weekends(10-11)

@Pakisan Pakisan self-assigned this Jun 8, 2023
@philCryoport
Copy link
Collaborator

@theschles @derberg

Will check on weekends(10-11)

Hi @Pakisan thoughts?

@Pakisan
Copy link
Member

Pakisan commented Jun 19, 2023

@theschles @derberg
Will check on weekends(10-11)

Hi @Pakisan thoughts?

We can try A variant, but I won't set up automated releases of a plugin now.

The main constraint is next - I check each new release by hand, by checking the behavior in each IDEA builds, to ensure that all workarounds, based on reflection api, work as expected and nothing will crash at runtime

@derberg
Copy link
Member Author

derberg commented Oct 3, 2023

few cents from my side, you can still do manual checks, just on a different release branch, and then have a PR with proper prefix, that after merging will trigger automation

@derberg
Copy link
Member Author

derberg commented Oct 3, 2023

what I mean is that in few other repos where we lack of full test suite, we also do manual tests, just before final release merge - still with automation in place

Copy link

github-actions bot commented Feb 1, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 1, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants