feat: 2.7.0 #141
Open
feat: 2.7.0 #141
+39
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: #133 Support IntelliJ IDEA 2024.3 (build 243)
Pakisan
requested review from
asyncapi-bot-eve,
theschles and
philCryoport
as code owners
|
Noting for the record the following errors and warnings occurred with That said, the build still "succeeded" |
|
Gradle Wrapper version needs to be updated to 8.11.1 |
Done |
philCryoport
requested changes
Dec 10, 2024
| @@ -8,7 +8,7 @@ plugins { | |||
| } | |||
|
|
|||
| group = "com.asyncapi.plugin.idea" | |||
| version = "2.6.0+jre17" | |||
| version = "2.7.0+jre17" | |||
There was a problem hiding this comment.
This should be
version = "2.7.0+jre21"
Also a few lines up: org.jetbrains.intellij.platform version 2.2.0 released Dec 6. The master branch has this...why isn't it here?
There was a problem hiding this comment.
+jre17 is a valid version of jdk
I fixed typos in CHANGELOG.md
| ## 2.7.0+jre21 | ||
| published to: | ||
| - [JetBrains marketplace](https://plugins.jetbrains.com/plugin/15673-asyncapi/versions/stable/643494) | ||
| - [GitHub](https://github.com/asyncapi/jasyncapi-idea-plugin/releases/new?tag=2.7.0%2Bjre17) |
There was a problem hiding this comment.
Tag should reference
jre21
NOT
jre17
There was a problem hiding this comment.
Fixed. jre17 is valid tag
| "2024.2.2", | ||
| "2024.2.3", | ||
| "2024.2.4", | ||
| "2024.2.5" | ||
| )) |
There was a problem hiding this comment.
What about 2024.3 and 2024.3.1?
It won't let me comment later in the file:
As discussed above, this should be based upon JDK 21:
- Please update both
jvmTargetto21 - Please update
JavaLanguageVersionto21
There was a problem hiding this comment.
2024.2.5 is a last version of IDEA for v2
2024.3 is supporting by v3 - https://github.com/asyncapi/jasyncapi-idea-plugin/tree/release/3.0.0
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed