Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade parser to version 3(next-major) #409

Closed
2 of 4 tasks
Tracked by #477
, #518
...
KhudaDad414 opened this issue Mar 20, 2023 · 13 comments · Fixed by #523
Closed
2 of 4 tasks
Tracked by #477
, #518
...

upgrade parser to version 3(next-major) #409

KhudaDad414 opened this issue Mar 20, 2023 · 13 comments · Fixed by #523
Assignees
@KhudaDad414 @Souvikns
Labels
enhancement New feature or request released

Comments

@KhudaDad414
Copy link
Member

KhudaDad414 commented Mar 20, 2023 •
edited
Loading

Reason/Context

Following a recent discussion with @Souvikns and @fmvilas it seems like it's a plausible idea to use the latest version (v3.0.0-next-major.5) of @asynapi/parser-js in Glee.

Why?

Scope

  • Migrate to Parser v3
  • Update MQTT Adapter along with its examples.
  • Update docs
  • Update tests
@KhudaDad414 KhudaDad414 added the enhancement New feature or request label Mar 20, 2023
@oviecodes
Copy link
Contributor

@KhudaDad414 I would like to take on this issue.

@oviecodes
Copy link
Contributor

oviecodes commented Mar 21, 2023 •
edited
Loading

hello @KhudaDad414 the latest version (v2.0.0-next-major.15) of @asynapi/parser-js is in pre-release, how do you recommend I go about this.

@KhudaDad414
Copy link
Member Author

@oviecodes by changing the current version to ^2.0.0-next-major.15 in package.json, running npm i, getting tons of errors, and going after each one. 😀

@oviecodes
Copy link
Contributor

oviecodes commented Mar 25, 2023 •
edited
Loading

@KhudaDad414 I've opened an issue on the @asyncapi/parser-js repository
asyncapi/parser-js#735

@KhudaDad414 KhudaDad414 mentioned this issue May 10, 2023
Closed
@ConnectBhawna
Copy link

Hey @KhudaDad414 I would like to take this issue.

@KhudaDad414
Copy link
Member Author

@ConnectBhawna that's great. @oviecodes do you plan to continue the work or should it be assigned to @ConnectBhawna?

@oviecodes
Copy link
Contributor

@KhudaDad414 please assign it to @ConnectBhawna , thanks.

@KhudaDad414
Copy link
Member Author

@ConnectBhawna, let me know if there was anything that I could help with. :)

@jonaslagoni jonaslagoni mentioned this issue Jun 5, 2023
Closed
7 tasks
@KhudaDad414 KhudaDad414 mentioned this issue Jul 14, 2023
Closed
10 tasks
@fmvilas fmvilas added this to Glee Sep 4, 2023
@fmvilas fmvilas mentioned this issue Sep 13, 2023
Closed
7 tasks
@Souvikns
Copy link
Member

/progress 10
I started with the Issue, reading parser-js docs.

@Souvikns Souvikns mentioned this issue Sep 20, 2023
Merged
@Souvikns
Copy link
Member

/progress 40
#523 is ready for review.

@KhudaDad414
Copy link
Member Author

/progress 50
MQTT adapter is compatible with v3(next branch) of parser-js.

@KhudaDad414 KhudaDad414 changed the title upgrade parser to version 2 upgrade parser to version 3(next-major) Oct 12, 2023
@KhudaDad414
Copy link
Member Author

/progress 90
PR is ready to merge #523

@github-project-automation github-project-automation bot moved this to Done in Glee Oct 20, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KhudaDad414 KhudaDad414

@Souvikns Souvikns

Labels
enhancement New feature or request released
Projects
Glee
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update parser-js to v2 Souvikns/glee
5 participants
@KhudaDad414 @Souvikns @oviecodes @asyncapi-bot @ConnectBhawna