Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix validating asyncapi document step #280

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

christianrowlands
Copy link
Contributor

Updated the github action for the validation step to the correct version

Updated the github action for the validation step to the correct version
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@christianrowlands christianrowlands changed the title Fix Validating AsyncAPI document step docs: fix validating asyncapi document step Jan 10, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR.

It actually reminded me that we should start working on new version of this action that do not use Generator as library but rather integrates the AsyncAPI CLI and let's people do more than just generation, but also validation and other stuff

@derberg
Copy link
Member

derberg commented Jan 11, 2023

/rtm

@derberg
Copy link
Member

derberg commented Jan 11, 2023

@christianrowlands I created #281 for further discussion, in case you are interested

@asyncapi-bot asyncapi-bot merged commit d487c05 into asyncapi:master Jan 11, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants