Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added the start command short description #1536

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ItshMoh
Copy link

@ItshMoh ItshMoh commented Sep 30, 2024

start_command
Added the short description for start command.
Description

Related issue(s)
#1534

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ItshMoh
Copy link
Author

ItshMoh commented Sep 30, 2024

hey @AayushSaini101 can you review the changes?

@@ -536,8 +536,11 @@
}
},
"node_modules/@asyncapi/minimaltemplate": {
"resolved": "test/fixtures/minimaltemplate",
"link": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItshMoh Why changes are needed in package-lock.json?

@AayushSaini101
Copy link
Contributor

@ItshMoh You are deleting the package-lock.json don't make any changes in this thanks

Copy link

sonarqubecloud bot commented Oct 2, 2024

@ItshMoh
Copy link
Author

ItshMoh commented Oct 2, 2024

@ItshMoh You are deleting the package-lock.json don't make any changes in this thanks

because on commitiing the package-lock.json there was merge conflict, so i thought that it will be better of to delete package-lock.json, should i delete it ?
cc @AayushSaini101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants