Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add checks to verify Extension of files #795

Merged
merged 6 commits into from
Sep 12, 2023
Merged

feat: add checks to verify Extension of files #795

merged 6 commits into from
Sep 12, 2023

Conversation

AayushSaini101
Copy link
Contributor

Close: Issue 794

github-actions[bot]
github-actions bot reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@AayushSaini101 AayushSaini101 changed the title Added Checks to verify Extension of files feat: Added Checks to verify Extension of files Sep 12, 2023
@AayushSaini101 AayushSaini101 changed the title feat: Added Checks to verify Extension of files feat: add checks to verify Extension of files Sep 12, 2023
@Souvikns
Copy link
Member

@AayushSaini101 you have some code smells as per sonarcloud.

@AayushSaini101
Copy link
Contributor Author

@AayushSaini101 you have some code smells as per sonarcloud.

@Souvikns Resolved

@Souvikns
Copy link
Member

Oh linter issue, just run npm run lint:fix, which should fix most of the issues. If you still have any other lint issues then try to fix them manually.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AayushSaini101
Copy link
Contributor Author

Oh linter issue, just run npm run lint:fix, which should fix most of the issues. If you still have any other lint issues then try to fix them manually.

@Souvikns Resolved

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 2837e15 into asyncapi:master Sep 12, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Souvikns Souvikns Souvikns approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@derberg derberg Awaiting requested review from derberg

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict the CLI to create only create file having yml and yaml extension.
4 participants
@AayushSaini101 @Souvikns @asyncapi-bot @aayushRedHat