Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convert to AsyncAPI from Postman collection support #1516

Closed
jonaslagoni opened this issue Sep 8, 2024 · 17 comments · Fixed by #1527
Closed

Add convert to AsyncAPI from Postman collection support #1516

jonaslagoni opened this issue Sep 8, 2024 · 17 comments · Fixed by #1527
Assignees
Labels
bounty AsyncAPI Bounty program related label released

Comments

@jonaslagoni
Copy link
Member

As the PR was just merged, it's now possible to convert Postman collection to AsyncAPI v3, and it should be possible to do this through the CLI. Checkout https://github.com/asyncapi/converter-js?tab=readme-ov-file#postman-collection-to-asyncapi-conversion for how to do it.

asyncapi/converter-js#276

@AayushSaini101
Copy link
Contributor

AayushSaini101 commented Sep 9, 2024

Thanks @Souvikns for submitting this issue for Bounty : ) I will take this

@Gmin2
Copy link
Contributor

Gmin2 commented Sep 11, 2024

Hey @jonaslagoni as i have done #1498 by #1500, i would like to take this

@AayushSaini101
Copy link
Contributor

Hey @jonaslagoni as i have done #1498, i would like to take this

@Gmin2 After discussion with @Souvikns we decided to submit this issue in the bounty program. Please let me start working on this issue, if you have any doubt let me know thanks for cooperation

@ItshMoh
Copy link

ItshMoh commented Sep 11, 2024

@jonaslagoni @Souvikns I want to take this issue. As i have made the specifications for conversion of postman collection into async api . I would love to work on this issue. Here is the link that pr.

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Sep 16, 2024
@aeworxet
Copy link
Contributor

Bounty Issue's service comment

Text labels: bounty/2024-Q4, bounty/medium, bounty/coding
First assignment to regular contributors: 2024-09-20 00:00:00 UTC+12:00
End Of Life after: 2024-10-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

@aeworxet
Copy link
Contributor

@AayushSaini101, @Gmin2, @ItshMoh, please describe how you would approach resolving this Bounty Issue.

@aeworxet aeworxet moved this to No Assignee in Bounty Program Sep 16, 2024
@dhruvilmehta
Copy link

I can see that we can only export the Postman collection in a JSON file and not in a YAML file. In the Pull Request mentioned, it's converting YAML postman collection file to Async API file. @ItshMoh, Can you guide me on how we can export the Postman collection to a YAML file?

@aeworxet
Copy link
Contributor

@dhruvilmehta
Bounty Issues are not collaborative work, and the Bounty Program is not a Mentorship Program. You are expected to be able to deliver the solution autonomously with only a little strategic guidance from the AsyncAPI Maintainer. Please describe how would you approach the resolution of this Bounty Issue, preferably with a coding draft.

@AayushSaini101
Copy link
Contributor

@Gmin2 Will work on this issue, We have discussed it, and He has done the prerequisite task of this issue

@Gmin2
Copy link
Contributor

Gmin2 commented Sep 18, 2024

We need to introduced a new option for format parameter named postman(as format was introduced in this ), and then we need to also add isPostmanCollection in convert.js as introduced in this, and finally we need to add a testcase for it

I would like to work on this as part of bounty program

cc @aeworxet, @Souvikns

@aeworxet
Copy link
Contributor

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Medium 2024-09-21 2024-10-07 2024-11-17 2024-10-20 2024-11-03 2024-11-17
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@aeworxet aeworxet moved this from No Assignee to In Progress in Bounty Program Sep 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Bounty Program Oct 2, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Done in CLI - Kanban Oct 2, 2024
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet
Copy link
Contributor

aeworxet commented Oct 3, 2024

Does the code work as expected after the merge of #1527?

@Gmin2
Copy link
Contributor

Gmin2 commented Oct 3, 2024

Does the code work as expected after the merge of #1527?

Screencast from 03-10-24 04:31:19 PM IST.webm
cc @aeworxet

@aeworxet
Copy link
Contributor

aeworxet commented Oct 3, 2024

@Souvikns, as the AsyncAPI Maintainer, who was responsible for the resolution of this Bounty Issue from the AsyncAPI's side, please confirm its technical resolution.

@Souvikns
Copy link
Member

Souvikns commented Oct 3, 2024

I confirm that this bounty issue is resolved succesfully.

@aeworxet
Copy link
Contributor

aeworxet commented Oct 3, 2024

Bounty Issue Is Completed 🎉

@Gmin2 (githubID 127925465), please go to the AsyncAPI page on Open Collective and submit an invoice for USD 200.00 with the expense title Bounty cli#1516, tag bounty, and full URL of this Bounty Issue in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label released
Projects
Status: Completed
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants