diff --git a/.github/workflows/automerge.yml b/.github/workflows/automerge.yml
index 9253675c..116b8065 100644
--- a/.github/workflows/automerge.yml
+++ b/.github/workflows/automerge.yml
@@ -45,7 +45,7 @@ jobs:
env:
GITHUB_TOKEN: "${{ secrets.GH_TOKEN }}"
GITHUB_LOGIN: asyncapi-bot
- MERGE_LABELS: ""
+ MERGE_LABELS: "!do-not-merge"
MERGE_METHOD: "squash"
MERGE_COMMIT_MESSAGE: "{pullRequest.title} (#{pullRequest.number})"
MERGE_RETRIES: "20"
diff --git a/.github/workflows/help-command.yml b/.github/workflows/help-command.yml
index f4955c22..d4ba4a44 100644
--- a/.github/workflows/help-command.yml
+++ b/.github/workflows/help-command.yml
@@ -27,13 +27,13 @@ jobs:
repo: context.repo.repo,
body: `Hello, @${{ github.actor }}! 👋🏼
- I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘
+ I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!
At the moment the following comments are supported in pull requests:
- - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
- - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
- - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.`
+ - \`/ready-to-merge\` or \`/rtm\` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
+ - \`/do-not-merge\` or \`/dnm\` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
+ - \`/autoupdate\` or \`/au\` - This comment will add \`autoupdate\` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.`
})
create_help_comment_issue:
@@ -51,10 +51,10 @@ jobs:
repo: context.repo.repo,
body: `Hello, @${{ github.actor }}! 👋🏼
- I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘
+ I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!
At the moment the following comments are supported in issues:
- - `/good-first-issue {js | ts | java | go | docs | design | ci-cd} ` or `/gfi {js | ts | java | go | docs | design | ci-cd} ` - label an issue as a `good first issue`.
- example: `/gfi js` or `/good-first-issue ci-cd`
- })
+ - \`/good-first-issue {js | ts | java | go | docs | design | ci-cd}\` or \`/gfi {js | ts | java | go | docs | design | ci-cd}\` - label an issue as a \`good first issue\`.
+ example: \`/gfi js\` or \`/good-first-issue ci-cd\``
+ })
\ No newline at end of file
diff --git a/CODEOWNERS b/CODEOWNERS
index 2feaec97..aa30dea0 100644
--- a/CODEOWNERS
+++ b/CODEOWNERS
@@ -8,10 +8,13 @@
* @derberg @fmvilas @dalelane @smoya @char0n @asyncapi-bot-eve
-/anypointmq/ @GeraldLoeffler
+/anypointmq/ @mboss37 @GeraldLoeffler
/ibmmq/ @rcoppen
+/jms/ @rcoppen @SrfHead
/kafka/ @lbroudoux @dalelane
/googlepubsub/ @whitlockjc
/solace/ @damaru-inc @CameronRushton
/pulsar/ @VisualBean
+/sns/ @dpwdec @iancooper
+/sqs/ @dpwdec @iancooper
*.json @KhudaDad414
diff --git a/anypointmq/README.md b/anypointmq/README.md
index a56540a4..1f0a43b5 100644
--- a/anypointmq/README.md
+++ b/anypointmq/README.md
@@ -89,7 +89,7 @@ The Anypoint MQ [Message Binding Object](https://github.com/asyncapi/spec/blob/m
Field Name | Type | Description
---|:---:|---
-`headers` | [Schema Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schemaObject) | **OPTIONAL**. A Schema object containing the definitions for Anypoint MQ-specific headers (so-called protocol headers). This schema MUST be of type `object` and have a `properties` key. Examples of Anypoint MQ protocol headers are `messageId` and `messageGroupId`.
+`headers` | [Schema Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schemaObject) \| [Reference Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#referenceObject) | **OPTIONAL**. A Schema object containing the definitions for Anypoint MQ-specific headers (so-called protocol headers). This schema MUST be of type `object` and have a `properties` key. Examples of Anypoint MQ protocol headers are `messageId` and `messageGroupId`.
`bindingVersion` | string | **OPTIONAL**, defaults to `latest`. The version of this binding.
Note that application headers must be specified in the [`headers` field of the standard Message Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#messageObjectHeaders) and are transmitted in the [`properties` section of the Anypoint MQ message](https://anypoint.mulesoft.com/exchange/portals/anypoint-platform/f1e97bc6-315a-4490-82a7-23abe036327a.anypoint-platform/anypoint-mq-broker/).
diff --git a/http/README.md b/http/README.md
index 7bb371d1..f2becbd3 100644
--- a/http/README.md
+++ b/http/README.md
@@ -31,7 +31,7 @@ This object MUST NOT contain any properties. Its name is reserved for future use
Field Name | Type | Description
---|:---:|---
`method` | string | The HTTP method for the request. Its value MUST be one of `GET`, `POST`, `PUT`, `PATCH`, `DELETE`, `HEAD`, `OPTIONS`, `CONNECT`, and `TRACE`.
-`query` | [Schema Object][schemaObject] | A Schema object containing the definitions for each query parameter. This schema MUST be of type object and have a properties key.
+`query` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) | A Schema object containing the definitions for each query parameter. This schema MUST be of type `object` and have a `properties` key.
`bindingVersion` | string | The version of this binding. If omitted, "latest" MUST be assumed.
This object MUST contain only the properties defined above.
@@ -72,7 +72,7 @@ This object contains information about the message representation in HTTP.
Field Name | Type | Description
---|:---:|---
-`headers` | [Schema Object][schemaObject] | A Schema object containing the definitions for HTTP-specific headers. This schema MUST be of type `object` and have a `properties` key.
+`headers` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) | A Schema object containing the definitions for HTTP-specific headers. This schema MUST be of type `object` and have a `properties` key.
`bindingVersion` | string | The version of this binding. If omitted, "latest" MUST be assumed.
This object MUST contain only the properties defined above.
@@ -95,4 +95,5 @@ channels:
bindingVersion: '0.2.0'
```
-[schemaObject]: https://www.asyncapi.com/docs/specifications/latest/#schemaObject
\ No newline at end of file
+[schemaObject]: https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schemaObject
+[referenceObject]: https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#referenceObject
diff --git a/jms/README.md b/jms/README.md
index 4e4d327d..28f2b0d6 100644
--- a/jms/README.md
+++ b/jms/README.md
@@ -3,25 +3,97 @@
This document defines how to describe JMS-specific information on AsyncAPI.
+## Versions
-## Version
+The version of this bindings specification is `0.0.1`.
+This is also the `bindingVersion` for all binding objects defined by this specification.
+In any given binding object, `latest` MAY alternatively be used to refer to the currently latest published version of this bindings specification.
-Current version is `0.1.0`.
+## Terminology
+
+The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this bindings specification are to be interpreted as described in IETF [RFC2119](https://www.ietf.org/rfc/rfc2119.txt).
+
+## Protocol
+
+These bindings use the `jms` [protocol](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#definitionsProtocol) in AsyncAPI documents to denote connections to and interactions with JMS message brokers.
+
+JMS is not technically a protocol, rather it is an API. A JMS Provider implements the JMS API and may define a protocol for implementing JMS API operations. Regardless, for the purposes of AsyncAPI we can treat it like a "protocol" to enable AsyncAPI definitions that are somewhat portable between various JMS Providers. If necessary, the user is free to combine this binding with other bindings that implement a JMS Provider (e.g. [Apache Pulsar](https://github.com/asyncapi/bindings/tree/master/pulsar), [Amazon SQS](https://github.com/asyncapi/bindings/tree/master/sqs), [IBM MQ](https://github.com/asyncapi/bindings/tree/master/ibmmq), etc.) to detail JMS Provider specific configuration.
+
+**NOTE** that from protocol version 3.0, this binding is compatible with [Jakarta Messaging](https://jakarta.ee/specifications/messaging).
+
+## Server Object
+
+The fields of the standard [Server Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#serverObject) are constrained and interpreted as follows:
+
+Server Object Field Name | Values for JMS Protocol | Description
+---|:---|:---
+`protocol` | `jms` | **REQUIRED**. MUST be `jms` for the scope of this specification.
+`url` | e.g., `jms://host:port` | **REQUIRED**. MUST be a URL containing the hostname and port of a JMS Broker.
+`protocolVersion` | e.g., `3.1` | **OPTIONAL**, defaults to `3.1`. If present MUST be the version indicator of the JMS API. Valid values are `1.0`, `1.0.1`, `1.0.1a`, `1.0.2`, `1.0.2a`, `1.0.2b`, `1.1`, `2.0`, `2.0a`, `2.1`, or `3.0`, `3.1.`.
## Server Binding Object
-This object MUST NOT contain any properties. Its name is reserved for future use.
-
+The JMS [Server Binding Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#server-bindings-object) is defined by a [JSON Schema](json_schemas/server.json), which defines these fields:
+
+Field Name | Type | Description
+---|:---:|---
+`jmsConnectionFactory` | string | **REQUIRED**. The classname of the [ConnectionFactory](https://docs.oracle.com/javaee/7/api/javax/jms/ConnectionFactory.html) implementation for the JMS Provider.
+`properties` | [Schema Array](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schemaArray) | **OPTIONAL**. Additional properties to set on the JMS ConnectionFactory implementation for the JMS Provider.
+`clientID` | string | **OPTIONAL**. A client identifier for applications that use this JMS connection factory. If the Client ID Policy is set to 'Restricted' (the default), then configuring a Client ID on the [ConnectionFactory](https://docs.oracle.com/javaee/7/api/javax/jms/ConnectionFactory.html) prevents more than one JMS client from using a connection from this factory.
+`bindingVersion` | string | **OPTIONAL**, defaults to `latest`. The version of this binding.
+
+### Examples
+
+The following example shows a `servers` object with a server binding object for `jms` with JMS specific properties:
+
+```yaml
+servers:
+ production:
+ url: jms://my-activemq-broker:61616
+ protocol: jms
+ protocolVersion: '1.1'
+ description: The production ActiveMQ broker accessed via JMS.
+ bindings:
+ jms:
+ # JMS protocol specific server details
+ jmsConnectionFactory: org.apache.activemq.ActiveMQConnectionFactory
+ properties:
+ - name: disableTimeStampsByDefault
+ value: false
+ clientID: my-application-1
+```
-
## Channel Binding Object
-This object MUST NOT contain any properties. Its name is reserved for future use.
+The JMS [Channel Binding Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#channel-bindings-object) is defined by a [JSON Schema](json_schemas/channel.json), which defines these fields:
+
+Field Name | Type | Description
+---|:---:|---
+`destination` | string | **OPTIONAL**, defaults to the channel name. The destination (queue) name for this channel. SHOULD only be specified if the channel name differs from the actual destination name, such as when the channel name is not a valid destination name according to the JMS Provider.
+`destinationType` | string | **OPTIONAL**, defaults to `queue`. The type of destination, which MUST be either `queue`, or `fifo-queue`. SHOULD be specified to document the messaging model (point-to-point, or strict message ordering) supported by this channel.
+`bindingVersion` | string | **OPTIONAL**, defaults to `latest`. The version of this binding.
+
+### Examples
+
+The following example shows a `channels` object with two channels, the second having a channel binding object for `jms`:
+
+```yaml
+channels:
+ user.signup:
+ description: This application receives command messages from this channel about users to sign up.
+ bindings:
+ jms:
+ destination: user-sign-up
+ destinationType: fifo-queue
+ bindingVersion: '0.0.1'
+ publish:
+ #...
+```
@@ -37,4 +109,50 @@ This object MUST NOT contain any properties. Its name is reserved for future use
## Message Binding Object
-This object MUST NOT contain any properties. Its name is reserved for future use.
+The JMS [Message Binding Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#message-bindings-object) is defined by a [JSON Schema](json_schemas/message.json), which defines these fields:
+
+Field Name | Type | Description
+---|:---:|---
+`headers` | [Schema Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schemaObject) | **OPTIONAL**. A Schema object containing the definitions for JMS specific headers (so-called protocol headers). This schema MUST be of type `object` and have a `properties` key. Examples of JMS protocol headers are `JMSMessageID`, `JMSTimestamp`, and `JMSCorrelationID`.
+`bindingVersion` | string | **OPTIONAL**, defaults to `latest`. The version of this binding.
+
+Note that application headers must be specified in the [`headers` field of the standard Message Object](https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#messageObjectHeaders) and are set as [Message Properties](https://docs.oracle.com/javaee/7/api/javax/jms/Message.html#Message%20Properties) of the JMS Message; how they are transmitted is defined by the JMS Provider and need not be considered here.
+In contrast, protocol headers such as `JMSMessageID` must be specified in the [`headers` field of the message binding object](#messageBindingObjectHeaders) and are transmitted in the [`headers` section of the JMS message](https://docs.oracle.com/javaee/7/api/javax/jms/Message.html#Message%20Headers).
+
+### Examples
+
+The following example shows a `message` object with both application specific headers, and a message binding object for `jms` with JMS specific headers:
+
+```yaml
+message:
+ messageId: my-message-1
+ bindings:
+ jms:
+ headers:
+ # JMS protocol specific message headers
+ required:
+ - JMSMessageID
+ properties:
+ JMSMessageID:
+ name: JMSMessageID
+ description: A unique message identifier. This may be set by your JMS Provider on your behalf.
+ type: string
+ JMSReplyTo:
+ name: JMSReplyTo
+ description: The queue or topic that the message sender expects replies to.
+ type: string
+ headers:
+ # Application specific message headers
+ required:
+ - MyToken
+ - MyOperationID
+ properties:
+ MyToken:
+ name: MyToken
+ description: Some sort of identificaton token for the publishing application.
+ type: string
+ MyOperationID:
+ name: MyOperationID
+ description: Some sort of unique identifier for the application operation to perform.
+ type: string
+```
diff --git a/kafka/README.md b/kafka/README.md
index cc75c77c..3e580a77 100644
--- a/kafka/README.md
+++ b/kafka/README.md
@@ -111,8 +111,8 @@ This object contains information about the operation representation in Kafka (eg
Field Name | Type | Description | Applicability [default] | Constraints
---|:---:|:---:|:---:|---
-`groupId` | [Schema Object][schemaObject] | Id of the consumer group. | OPTIONAL | -
-`clientId` | [Schema Object][schemaObject] | Id of the consumer inside a consumer group. | OPTIONAL | -
+`groupId` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) | Id of the consumer group. | OPTIONAL | -
+`clientId` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) | Id of the consumer inside a consumer group. | OPTIONAL | -
`bindingVersion` | string | The version of this binding. If omitted, "latest" MUST be assumed. | OPTIONAL [`latest`] | -
This object MUST contain only the properties defined above.
@@ -145,7 +145,7 @@ This object contains information about the message representation in Kafka.
Field Name | Type | Description
---|:---:|---
-`key` | [Schema Object][schemaObject] \| [AVRO Schema Object](https://avro.apache.org/docs/current/spec.html) | The message key. **NOTE**: You can also use the [reference object](https://asyncapi.io/docs/specifications/v2.4.0#referenceObject) way.
+`key` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) \| [AVRO Schema Object](https://avro.apache.org/docs/current/spec.html) | The message key. **NOTE**: You can also use the [reference object](https://asyncapi.io/docs/specifications/v2.4.0#referenceObject) way.
`schemaIdLocation` | string | If a Schema Registry is used when performing this operation, tells where the id of schema is stored (e.g. `header` or `payload`). | OPTIONAL | MUST NOT be specified if `schemaRegistryUrl` is not specified at the Server level
`schemaIdPayloadEncoding` | string | Number of bytes or vendor specific values when schema id is encoded in payload (e.g `confluent`/ `apicurio-legacy` / `apicurio-new`). | OPTIONAL | MUST NOT be specified if `schemaRegistryUrl` is not specified at the Server level
`schemaLookupStrategy` | string | Freeform string for any naming strategy class to use. Clients should default to the vendor default if not supplied. | OPTIONAL | MUST NOT be specified if `schemaRegistryUrl` is not specified at the Server level
@@ -189,3 +189,4 @@ channels:
```
[schemaObject]: https://www.asyncapi.com/docs/specifications/2.4.0/#schemaObject
+[referenceObject]: https://www.asyncapi.com/docs/specifications/2.4.0/#referenceObject
diff --git a/sns/README.md b/sns/README.md
index 6a0f81d9..4ef43ec5 100644
--- a/sns/README.md
+++ b/sns/README.md
@@ -15,23 +15,283 @@ Current version is `0.1.0`.
This object MUST NOT contain any properties. Its name is reserved for future use.
-
-
## Channel Binding Object
-This object MUST NOT contain any properties. Its name is reserved for future use.
+This object contains information about the channel representation in SNS.
+
+We represent an AsyncAPI Channel with a Topic in SNS. The bindings here allow definition of a topic within SNS. We provide properties on the binding that allow creation of a topic in infrastructure-as-code scenarios. Be aware that although the binding offers that flexibility, it may be more maintainable to specify properties such as SNS Access Control Policy outside of AsyncAPI.
+
+SNS supports many optional properties. To mark a channel as SNS, but use default values for the channel properties, just use an empty object {}.
+
+### Fields
+
+|Field Name | Type | Description|
+|---|:---:|---|
+| `name` | string | **Required.** The name of the topic. Can be different from the channel name to allow flexibility around AWS resource naming limitations.|
+| `ordering` | [ordering](#ordering)| **Optional.** By default, we assume an unordered SNS topic. This field allows configuration of a FIFO SNS Topic. |
+| `policy` |[policy](#policy) | **Optional.** The security policy for the SNS Topic |
+| `tags` |Object | **Optional.** Key-value pairs that represent AWS tags on the topic. |
+|`bindingVersion` | string | **Optional**, defaults to `latest`. The version of this binding.|
+
+### Schemas
+
+#### Ordering
+|Field Name | Type | Description|
+|---|:---:|---|
+| `type` | string | **Required.** Defines the type of SNS Topic. Can be either `standard` or `FIFO`. |
+| `contentBasedDeduplication` | boolean | **Optional.** Whether the de-duplication of messages should be turned on. Defaults to `false`|
+
+#### Policy
+|Field Name | Type | Description|
+|---|:---:|---|
+| `statements` | [[Statement](#statement)] | **Required.** An array of Statement objects, each of which controls a permission for this topic |
+
+#### Statement
+|Field Name | Type | Description|
+|---|:---:|---|
+| `effect` | string |**Required.** Either "Allow" or "Deny"|
+| `principal` | string or array of string |**Required.** The AWS account or resource ARN that this statement applies to|
+| `action` | string or array of string |**Required.** The SNS permission being allowed or denied e.g. sns:Publish|
+
+##### Examples
+Just use defaults
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up to our service
+ bindings:
+ sns: {}
+```
+
+Minimal definition, just policy
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up to our service
+ bindings:
+ sns:
+ policy:
+ statements:
+ - effect : Allow
+ principal: *
+ action: SNS:Publish
+```
## Operation Binding Object
-This object MUST NOT contain any properties. Its name is reserved for future use.
+This object contains information operation binding in SNS.
+
+We represent SNS producers via a **subscribe** Operation Object. In simple cases this may not require configuration, and can be shown as an empty SNS Binding Object i.e. {} if you need to explicitly indicate how a producer publishes to the channel.
+
+We represent SNS consumers via a **publish** Operation Object. These consumers need an SNS Subscription that defines how they consume from SNS i.e. the protocol that they use, and any filters applied.
+
+The SNS binding does not describe the receiver.If you wish to define the receiver, add a **publish** Operation Binding Object for that receiver. For example, if you send message to an SQS queue from an SNS Topic, you would add a protocol of 'sqs' and an Identifier object for the queue. That identifier could be an ARN of a queue defined outside of the scope of AsyncAPI, but if you wanted to define the receiver you would use the name of a queue defined in an SQS Binding on the **publish** Operation Binding Object.
+
+We support an array of consumers via the **consumers** field. This allows you to represent multiple protocols consuming an SNS Topic in one file. You may also use it for multiple consumers with the same protocol, instead of representing each consumer in a separate file.
+
+### Fields
+
+| Field Name | Type | Applies To | Description |
+|---|:---:|:---:|---|
+| `topic` | [identifier](#identifier) |Publish, Subscribe| **Optional.** Often we can assume that the SNS Topic is the channel name-we provide this field in case the you need to supply the ARN, or the Topic name is not the channel name in the AsyncAPI document.|
+| `consumers` | [[Consumer](#consumer)] |Publish| **Required.** The protocols that listen to this topic and their endpoints.|
+| `deliveryPolicy` | [deliveryPolicy](#delivery-policy) |Subscribe| **Optional.** Policy for retries to HTTP. The field is the default for HTTP receivers of the [SNS Topic](https://docs.aws.amazon.com/sns/latest/api/API_CreateTopic.html) which may be overridden by a specific consumer.|
+|`bindingVersion` | string |Publish, Subscribe| **Optional**, defaults to `latest`. The version of this binding.|
+
+### Schemas
+
+#### Consumer
+
+| Field Name | Type | Description |
+|---|:---:|---|
+| `protocol` | string | **Required.** The protocol that this endpoint receives messages by. Can be `http`, `https`, `email`, `email-json`, `sms`, `sqs`, `application`, `lambda` or `firehose` |
+| `endpoint` |[identifier](#identifier)| **Required.** The endpoint messages are delivered to. |
+| `filterPolicy` | object | **Optional.** Only receive a subset of messages from the channel, determined by this policy. |
+| `filterPolicyScope` | string | **Optional.** Determines whether the FilterPolicy applies to MessageAttributes (default) or MessageBody. |
+| `rawMessageDelivery` | boolean | **Required.** If *true* AWS SNS attributes are removed from the body, and for SQS, SNS message attributes are copied to SQS message attributes. If *false* the SNS attributes are included in the body. |
+| `redrivePolicy` | [redrivePolicy](#redrive-policy) | **Optional.** Prevent poison pill messages by moving un-processable messages to an SQS dead letter queue. |
+| `deliveryPolicy` | [deliveryPolicy](#delivery-policy) | **Optional.** Policy for retries to HTTP. The parameter is for that [SNS Subscription](https://docs.aws.amazon.com/sns/latest/api/API_Subscribe.html) and overrides any policy on the [SNS Topic](https://docs.aws.amazon.com/sns/latest/api/API_CreateTopic.html). |
+| `displayName` | string |**Optional.** The display name to use with an SMS subscription |
+
+
+#### Delivery Policy
+|Field Name | Type | Description|
+|---|:---:|---|
+| `minDelayTarget` | integer | **Optional.** The minimum delay for a retry in seconds |
+| `maxDelayTarget` | integer | **Optional.** The maximum delay for a retry in seconds |
+| `numRetries` | integer | **Optional.** The total number of retries, including immediate, pre-backoff, backoff, and post-backoff retries |
+| `numNoDelayRetries` | integer | **Optional.** The number of immediate retries (with no delay) |
+| `numMinDelayRetries` | integer | **Optional.** The number of immediate retries (with delay) |
+| `numMaxDelayRetries` | integer | **Optional.** The number of post-backoff phase retries, with the maximum delay between retries |
+| `backoffFunction` | string, one of: arithmetic, exponential, geometric or linear | **Optional.** The algorithm for backoff between retries |
+| `maxReceivesPerSecond` | integer | **Optional.** The maximum number of deliveries per second, per subscription |
+
+#### Identifier
+|Field Name | Type | Description|
+|---|:---:|---|
+|`url` |string| **Optional.** The endpoint is a URL |
+|`email` |string| **Optional.** The endpoint is an email address |
+|`phone` |string| **Optional.** The endpoint is a phone number|
+|`arn` |string| **Optional.** The target is an [ARN](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html). For example, for SQS, the identifier may be an ARN, which will be of the form: ["arn:aws:sqs:{region}:{account-id}:{queueName}"](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html)|
+|`name` |string| **Optional.** The endpoint is identified by a name, which corresponds to an identifying field called 'name' of a binding for that protocol on this **publish** Operation Object. For example, if the protocol is 'sqs' then the name refers to the name field **sqs** binding. We don't use $ref because we are referring, not including. |
+
+We provide an Identifer Object to support providing the identifier of an externally defined endpoint for this SNS *publication* to target, or an endpoint on another binding against this Operation Object (via the name field).
+
+#### Redrive Policy
+
+|Field Name | Type | Description|
+|---|:---:|---|
+| `deadLetterQueue` |[Identifier](#identifier)| **Required.** The SQS queue to use as a dead letter queue (DLQ). Note that you may have a Redrive Policy to put messages that cannot be delivered to an SQS queue, even if you use another protocol to consume messages from the queue, so it is defined at the level of the SNS Operation Binding Object in a Consumer Object (and is applied as part of an [SNS Subscription](https://docs.aws.amazon.com/sns/latest/dg/sns-create-subscribe-endpoint-to-topic.html)). The SQS Binding describes how to define an SQS Binding that supports defining the target SQS of the Redrive Policy. |
+| `maxReceiveCount` |integer| **Optional.** The number of times a message is delivered to the source queue before being moved to the dead-letter queue. Defaults to 10. |
+
+### Examples
+
+#### SNS to SQS Pub-Sub
+
+[](SNS-SQS-Pub-Sub.png)
+
+We are producing to an SNS channel
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ binding :
+ sns: {} # Indicates that the channel is an SNS Topic
+ subscribe:
+ operationId: sendMessage
+ description: send messages to the topic
+ bindings:
+ sns:
+ consumers:
+ - protocol: sqs
+ endpoint:
+ name: myQueue
+ rawMessageDelivery: false
+```
+
+We are consuming an SNS channel, using an SQS queue. A separate file specifies the producer, and has the SNS Bindings for the channel. For this reason we do not repeat the SNS binding information for the channel here, to avoid duplicated definitions diverging. Instead we just define the **publish** Operation Binding.
+
+In this version, the SQS queue is defined elsewhere, and we just reference via its ARN. It is worth noting that this couples the specification to the AWS *region* and *account*, which are part of the ARN, and if we moved the queue to a new region or account was this specification would need to be updated to reflect that.
+
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ publish:
+ operationId: receiveMessage
+ description: receive messages from the topic
+ bindings:
+ sns:
+ consumers:
+ - protocol: sqs
+ endpoint:
+ arn: arn:aws:sqs:us-west-2:123456789012:UserSignedUpQueue
+ rawMessageDelivery: true
+```
+
+We are consuming an SNS channel, using an SQS queue. A separate file specifies the producer, and has the SNS Bindings for the channel. For this reason we do not repeat the SNS binding information for the channel here, to avoid duplicated definitions diverging. Instead we just define the **publish** Operation Binding.
+
+In this version, the SQS queue is defined in this file, and we reference it by name. For brevity that definition is not shown here. See the SQS Binding Object for more.
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ publish:
+ operationId: receiveMessage
+ description: receive messages from the topic
+ bindings:
+ sns:
+ consumers:
+ - protocol: sqs
+ endpoint:
+ name: user-signedup-queue # refers to a queue defined in this file, but not shown in this example
+ rawMessageDelivery: true
+ filterPolicy:
+ reason:
+ anything-but: password-reset
+ redrivePolicy:
+ deadLetterQueue:
+ name: user-signedup-queue-dlq # refers toa queue defined in this file, but not show in this example
+```
+
+#### SNS to HTTP Pub Sub
+
+[](SNS-HTTP.png)
+
+We are producing to an SNS channel.
+
+In this version, we define a default delivery policy for any HTTP based consumers
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ bindings:
+ sns:
+ policy:
+ statements:
+ - effect : Allow
+ principal: *
+ action: SNS:Publish
+ subscribe:
+ operationId: sendMessage
+ description: send messages to the topic
+ bindings:
+ sns:
+ deliveryPolicy:
+ minDelayTarget: 1
+ maxDelayTarget: 60
+ numRetries: 50
+ numNoDelayRetries: 3
+ numMinDelayRetries: 2
+ numMaxDelayRetries: 35
+ backoffFunction: exponential
+ maxReceivesPerSecond: 10
+```
+We are consuming an SNS channel, using an HTTP endpoint, which is defined in this AsyncAPI file. For brevity we do not show an http endpoint here. The delivery policy here is defined for the http consumer and overrides any policy set by the producer
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ bindings:
+ sns: {} # Indicates that the channel is an SNS Topic, but assumes defined by producer
+ publish:
+ operationId: receiveMessage
+ description: receive messages from the topic
+ bindings:
+ sns:
+ - protocol: http
+ endpoint:
+ url: http://login.my.com/user/new
+ filterPolicy:
+ reason:
+ anything-but: password-reset
+ filterPolicyScope: MessageBody
+ deliveryPolicy:
+ minDelayTarget: 1
+ maxDelayTarget: 120
+ numRetries: 30
+ numNoDelayRetries: 3
+ numMinDelayRetries: 2
+ numMaxDelayRetries: 25
+ backoffFunction: exponential
+ maxReceivesPerSecond: 20
+ redrivePolicy:
+ deadLetterQueue:
+ name: user-signedup-queue-dlq # refers toa queue defined in this file, but not show in this example
+```
diff --git a/sns/SNS-HTTP.png b/sns/SNS-HTTP.png
new file mode 100644
index 00000000..72e52c73
Binary files /dev/null and b/sns/SNS-HTTP.png differ
diff --git a/sns/SNS-SQS-Pub-Sub.png b/sns/SNS-SQS-Pub-Sub.png
new file mode 100644
index 00000000..033d6de7
Binary files /dev/null and b/sns/SNS-SQS-Pub-Sub.png differ
diff --git a/sqs/README.md b/sqs/README.md
index 8bccca3f..5f8281ed 100644
--- a/sqs/README.md
+++ b/sqs/README.md
@@ -2,12 +2,17 @@
This document defines how to describe SQS-specific information on AsyncAPI.
+SQS can be used both stand-alone as a point-to-point and paired with SNS and as a publish-subscribe channel (where SQS is the endpoint that SNS delivers messages to). For this reason we define a Queue schema, and reference that schema from both a Channel Binding Object and a **publish** Operation Binding Object.
+
+For point-to-point scenarios, use the Channel Binding Object, as producers send to the queue and consumers receive from it directly.
+
+For publish-subscribe scenarios, use as a **publish** Operation Binding Object, as the producer sends to SNS and the consumer receives via SQS.
+
## Version
-Current version is `0.1.0`.
-
+Current version is `0.2.0`.
@@ -15,23 +20,220 @@ Current version is `0.1.0`.
This object MUST NOT contain any properties. Its name is reserved for future use.
-
-
-## Channel Binding Object
-
-This object MUST NOT contain any properties. Its name is reserved for future use.
-
+## Channel Binding Object
+
+Use the Channel Binding Operation for Point-to-Point SQS channels.
+
+There are three likely scenarios for use of the Channel Binding Object:
+
+- One file defines both publish and subscribe operations, for example if we were implementing the work queue pattern to offload work from an HTTP API endpoint to a worker process. In this case the channel would be defined on the Channel Object in that single file.
+- The producer and consumer both have an AsyncAPI specification file, and the producer is raising an event, for example interop between microservices, and the producer 'owns' the channel definition and thus has the SQS Binding on its Channel Object.
+- The producer and consumer both have an AsyncAPI specification file, and the consumer receives commands, for example interop between microservices, and the consumer 'owns' the channel definition and thus has the SQS Binding on its Channel Object.
+
+An SQS queue can set up a Dead Letter Queue as part of a Redelivery Policy. To support this requirement, the Channel Binding Object allows you to define both a Queue Object to use as the Channel or target in a *publish* Operation and a Dead Letter Queue. You can then refer to the Dead letter Queue in the Redrive Policy using the Identifier Object and setting the *name* field to match the *name* field of your Dead Letter Queue Object. (If you define the DLQ externally, the Identifier also supports an ARN).
+
+### Fields
+|Field Name | Type | Description|
+|---|:---:|---|
+| `queue` | [Queue](#queue)| **Required.** A definition of the queue that will be used as the channel. |
+| `deadLetterQueue` | [Queue](#queue)| **Optional.** A definition of the queue that will be used for un-processable messages. |
+|`bindingVersion` | string | **Optional**, defaults to `latest`. The version of this binding.|
+
+### Schemas
+
+#### Queue
+|Field Name | Type | Description|
+|---|:---:|---|
+| `name` | string | **Required.** The name of the queue. When an [SNS Operation Binding Object]() references an SQS queue by name, the identifier should be the one in this field.|
+| `fifoQueue` | boolean | **Required.** Is this a FIFO queue? |
+| `deduplicationScope` | string | **Optional.** Specifies whether message deduplication occurs at the message group or queue level. Valid values are `messageGroup` and `queue`. **This property applies only to high throughput for FIFO queues.** |
+| `fifoThroughputLimit` | string | **Optional.** Specifies whether the FIFO queue throughput quota applies to the entire queue or per message group. Valid values are `perQueue` and `perMessageGroupId`. **The `perMessageGroupId` value is allowed only when the value for DeduplicationScope is `messageGroup`. Setting both these values as such will enable high throughput on a FIFO queue. As above, this property applies only to high throughput for FIFO queues.** |
+| `deliveryDelay` | integer | **Optional.** The number of seconds to delay before a message sent to the queue can be received. Used to create a *delay queue*. Range is 0 to 15 minutes. Defaults to 0. |
+| `visibilityTimeout` |integer| **Optional.** The length of time, in seconds, that a consumer locks a message - hiding it from reads - before it is unlocked and can be read again. Range from 0 to 12 hours (43200 seconds). Defaults to 30 seconds. |
+| `receiveMessageWaitTime` |integer| **Optional.** Determines if the queue uses [short polling](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-short-and-long-polling.html) or [long polling](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-short-and-long-polling.html). Set to zero (the default) the queue reads available messages and returns immediately. Set to a non-zero integer, long polling waits the specified number of seconds for messages to arrive before returning. |
+| `messageRetentionPeriod` |integer| **Optional.** How long to retain a message on the queue in seconds, unless deleted. The range is 60 (1 minute) to 1,209,600 (14 days). The default is 345,600 (4 days). |
+| `redrivePolicy` | [Redrive Policy](#redrive-policy) | **Optional.** Prevent poison pill messages by moving un-processable messages to an SQS dead letter queue.|
+| `policy` |[Policy](#policy) | **Optional.** The security policy for the SQS Queue |
+| `tags` |Object | **Optional.** Key-value pairs that represent AWS tags on the queue. |
+
+#### Identifier
+|Field Name | Type | Description|
+|---|:---:|---|
+|`arn` |string| **Optional.** The target is an [ARN](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html). For example, for SQS, the identifier may be an ARN, which will be of the form: ["arn:aws:sqs:{region}:{account-id}:{queueName}"](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html)|
+|`name` |string| **Optional.** The endpoint is identified by a name, which corresponds to an identifying field called 'name' of a binding for that protocol on this **publish** Operation Object. For example, if the protocol is 'sqs' then the name refers to the name field **sqs** binding|
+
+#### Policy
+|Field Name | Type | Description|
+|---|:---:|---|
+| `Statements` | [Statement](#statement) | **Required.** An array of Statement objects, each of which controls a permission for this queue. |
+
+#### Redrive Policy
+|Field Name | Type | Description|
+|---|:---:|---|
+| `deadLetterQueue` |[Identifier](#identifier)| The SQS queue to use as a dead letter queue (DLQ) |
+| `maxReceiveCount` |integer| **Optional.** The number of times a message is delivered to the source queue before being moved to the dead-letter queue. Default is 10. |
+
+#### Statement
+|Field Name | Type | Description|
+|---|:---:|---|
+| `effect` | string |**Required.** Either "Allow" or "Deny"|
+| `principal` | string or array of string |**Required.** The AWS account or resource ARN that this statement applies to|
+| `action` | string or array of string |**Required.** The SQS permission being allowed or denied e.g. sqs:ReceiveMessage |
## Operation Binding Object
-This object MUST NOT contain any properties. Its name is reserved for future use.
+### SQS Point-To-Point
+
+Because we have defined Queue as part of the Channel Binding Binding object, we do not require Binding information for the **publish** Operation Object of the **subscribe** Operation Object. You can use an empty Queue object ({}) to denote the Binding on the Operation Object, if you want to indicate the protocol used to send or receive for generation purposes such as Infrastructure As Code.
+
+### SNS to SQS Pub-Sub
+
+Use the Operation Binding Object when SQS is listening to an SNS Topic. In this case we need to define both an SQS Operation Binding Objects on the receiver **publish** Operation Object to represent the queue definition and we need to define an SNS Operation Binding Object to define the Subscription to SNS that makes your queue a receiver of that endpoint.
+
+Assuming you have separate AsyncAPI specifications for the producer and the consumer, we would assume the following bindings would appear for an SNS producer and an SQS consumer.
+Producer: SNS Channel Binding Object, SNS **subscribe** Operation Binding Object [if required]
+Consumer: SNS **publish** Operation Binding Object, SQS **publish** Operation Binding Object
+- We assume that the SNS binding information only needs to be present in the producer file (although defining it in both is allowable) and any infrastructure as code dependencies can recognize this.
+
+
+On an Operation Binding Object we support an array of Queue objects. Members of this array may be Queue Objects that define the *endpoint* field required by an [SNS Operation Object]() delivering by the SQS protocol or Queue Objects that define the Dead Letter Queue used by either the Redrive Policy of the SNS Subscription (see the SNS Binding Object) or the [Redrive Policy of the SQS Queue](#redrive-policy). The name of the Queue Object is used by an Identifier field on either the *endpoint* field of the SNS Operation Object of *deadLetterQueue* on the Redrive Policy to identify the required member of this array.
+
+
+### Fields
+|Field Name | Type | Description|
+|---|:---:|---|
+| `queues` | [[Queue](#queue)]| **Required.** Queue objects that are either the *endpoint* for an SNS Operation Binding Object, or the *deadLetterQueue* of the SQS Operation Binding Object |
+|`bindingVersion` | string | **Optional**, defaults to `latest`. The version of this binding.|
+
+### Examples
+
+#### SQS Point-To-Point
+
+[](SQS-Point-To-Point.png)
+
+In this example, we are using SQS for a point-to-point channel. For this example, we assume that we are defining two microservices that communicate over a shared SQS channel, with the consumer receiving events over that channel and the producer owning the channel definition.
+
+The producer file would look like this:
+
+```yaml
+channels:
+ user-signedup:
+ bindings:
+ sqs:
+ queue:
+ name: user-signedup-queue
+ fifoQueue: false
+ receiveMessageWaitTime: 4
+ redrivePolicy:
+ deadLetterQueue:
+ name: user-signedup-dlq
+ policy:
+ statements:
+ - effect : Allow
+ principal: *
+ action: Sqs:SendMessage
+ - effect : Allow
+ principal: *
+ action: Sqs:ReceiveMessage
+ deadLetterQueue:
+ name: user-signedup-dlq
+ messageRetentionPeriod: 1209600
+ fifoQueue: false
+ subscribe:
+ operationId: sendMessage
+ description: sends messages when a user has signed up
+ bindings:
+ sqs: {}
+
+```
+In this case we can minimize duplicated information by omitting the binding in our specification, and assume it is picked up from the producer file. We can use an empty object to indicate the SQS Binding on the **publish** Operation Object, if need a marker for generation, otherwise we could omit the Operation Binding Object.
+
+```yaml
+channels:
+ user-signedup:
+ publish:
+ operationId: receiveMessage
+ description: receives a messages when a user has signed up
+ bindings:
+ sqs: {}
+
+```
+
+#### SNS to SQS Pub-Sub
+
+[](SNS-SQS-Pub-Sub.png)
+
+In this example, we are using SNS for the channel, and SQS to receive from SNS.
+
+
+The producer files looks like this (see the [SNS Binding]() for more).
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ binding :
+ sns: {} # Indicates that the channel is an SNS Topic
+ subscribe:
+ operationId: sendMessage
+ description: send messages to the topic
+ bindings:
+ sns:
+ policy:
+ statements:
+ - effect : Allow
+ principal: *
+ action: SNS:Publish
+```
+
+And the consumer file would look like this. Note that for simplicity, we choose not to repeat the SNS Binding on the Consumer as it does not 'own' the channel.
+
+
+```yaml
+channels:
+ user-signedup:
+ description: A user has signed up for our service
+ publish:
+ operationId: receiveMessage
+ description: receive messages from the topic
+ bindings:
+ sns:
+ consumers:
+ - protocol: sqs
+ endpoint:
+ name: user-signedup-queue
+ rawMessageDelivery: true
+ filterPolicy:
+ attributes:
+ reason:
+ anything-but: password-reset
+ redrivePolicy:
+ deadLetterQueue:
+ name: user-signedup-queue-dlq
+ sqs:
+ queues:
+ - name: user-signedup-queue
+ fifoQueue: false
+ receiveMessageWaitTime: 4
+ policy:
+ statements:
+ - effect : Allow
+ principal: *
+ action: Sqs:SendMessage
+ - effect : Allow
+ principal: *
+ action: Sqs:ReceiveMessage
+ - name: user-signedup-dlq
+ messageRetentionPeriod: 1209600
+ fifoQueue: false
+```
diff --git a/sqs/SNS-SQS-Pub-Sub.png b/sqs/SNS-SQS-Pub-Sub.png
new file mode 100644
index 00000000..033d6de7
Binary files /dev/null and b/sqs/SNS-SQS-Pub-Sub.png differ
diff --git a/sqs/SQS-Point-To-Point.png b/sqs/SQS-Point-To-Point.png
new file mode 100644
index 00000000..a94cfc7b
Binary files /dev/null and b/sqs/SQS-Point-To-Point.png differ
diff --git a/websockets/README.md b/websockets/README.md
index 47b18121..8d67e068 100644
--- a/websockets/README.md
+++ b/websockets/README.md
@@ -29,8 +29,8 @@ When using WebSockets, the channel represents the connection. Unlike other proto
Field Name | Type | Description
---|:---:|---
`method` | string | The HTTP method to use when establishing the connection. Its value MUST be either `GET` or `POST`.
-`query` | [Schema Object][schemaObject] | A Schema object containing the definitions for each query parameter. This schema MUST be of type `object` and have a `properties` key.
-`headers` | [Schema Object][schemaObject] | A Schema object containing the definitions of the HTTP headers to use when establishing the connection. This schema MUST be of type `object` and have a `properties` key.
+`query` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) | A Schema object containing the definitions for each query parameter. This schema MUST be of type `object` and have a `properties` key.
+`headers` | [Schema Object][schemaObject] \| [Reference Object](referenceObject) | A Schema object containing the definitions of the HTTP headers to use when establishing the connection. This schema MUST be of type `object` and have a `properties` key.
`bindingVersion` | string | The version of this binding. If omitted, "latest" MUST be assumed.
This object MUST contain only the properties defined above.
@@ -49,4 +49,5 @@ This object MUST NOT contain any properties. Its name is reserved for future use
This object MUST NOT contain any properties. Its name is reserved for future use.
-[schemaObject]: https://www.asyncapi.com/docs/specifications/2.0.0/#schemaObject
\ No newline at end of file
+[schemaObject]: https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schemaObject
+[referenceObject]: https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#referenceObject
\ No newline at end of file