Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT retain flag should be applied only to publish operations #187

Closed
KhudaDad414 opened this issue Feb 20, 2023 · 8 comments
Closed

MQTT retain flag should be applied only to publish operations #187

KhudaDad414 opened this issue Feb 20, 2023 · 8 comments
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@KhudaDad414
Copy link
Member

Reason/Context

The retain flag in MQTT binding should only be applied when the type of operation is publish. It can be applied to publish and subscribe according to the current bindings.

Solution

Remove subscribe from the Applies to column in the operation binding object.

@KhudaDad414 KhudaDad414 added the enhancement New feature or request label Feb 20, 2023
@KhudaDad414
Copy link
Member Author

/gfi docs

@asyncapi-bot asyncapi-bot added area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Feb 20, 2023
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kushalnl7
Copy link

Hi, I am interested to do this. Can I try this?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 22, 2023
@satyavalli5408
Copy link

Can i solve this?

@github-actions github-actions bot removed the stale label Jun 23, 2023
@AnimeshKumar923
Copy link

Any update on this? I see a PR (#188 ) opened to fix this issue.
ping: @KhudaDad414 @derberg @dalelane @smoya @char0n

@char0n
Copy link
Collaborator

char0n commented Oct 26, 2023

@AnimeshKumar923 working on pushing the #188 forward by pinging the PR author.

@jonaslagoni
Copy link
Member

Already solved in the v3 compatible bindings 🙂 https://github.com/asyncapi/bindings/tree/master/mqtt#operation-binding-object

@fmvilas fmvilas closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants