feat: add support for request and reply pattern #795
Conversation
chore(release): v1.0.0-next.1
…message from oneOf (asyncapi#335)
chore(release): v1.0.0-next.2
chore(release): v1.0.0-next.3
chore(release): v1.0.0-next.4
|
dunno but can't refresh locally 🤷🏼 issue: reply for
tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/kraken-websocket-request-reply-message-filter-in-reply-asyncapi.yml and works like a charm issue: Playground crash. Cannot figure errors, strange as latest parser is used and the bug with kafka binding was supposed to be fixed there. Will investigate tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/streetlights-kafka-asyncapi.yml issue: no operations rendered, just last but not least - I think #795 (comment) is broken again |
|
@derberg I added suggested changes. Kindly give it a look :) |
did you have a chance to check what is wrong here?
Operations are still empty also some issue with rendering of examples in reply
|
@derberg Based on my investigation, The issue is actually related to the way Parser is handling the Operation traits. I get the list of Operations only when I get rid of the traits. cc @smoya |
Same as last time. Playground only renders when I remove the Message level bindings 🤷🏾♂️ |
|
@AceTheCreator I see for message issue you have created asyncapi/parser-js#877, and what about operations? maybe update |
|
so in this PR only styling of examples left? |
Yes |
|
@derberg Examples styling fixed |
derberg
changed the title
library/package.json
Outdated
| "@asyncapi/protobuf-schema-parser": "3.0.0", | ||
| "@asyncapi/parser": "^3.0.0-next-major-spec.7", |
There was a problem hiding this comment.
please use latest v3.0.0-next-major-spec.10
playground/package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "react-scripts": "3.1.2" | |||
| }, | |||
| "scripts": { | |||
| "start": "react-app-rewired start", | |||
| "start": "react-app-rewired --openssl-legacy-provider start", | |||
There was a problem hiding this comment.
please revert, as with this I cannot start local playground anymore, and need to manually remove that flag
|
Kudos, SonarCloud Quality Gate passed!
|
|
added suggested changes @derberg |
|
/rtm |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds support for request and reply patterns by introducing a new component that renders reply information such as:
address,description,message(s)and so onaddress,location, anddescriptionAsyncApi.React.Playground.App.-.16.November.2023.mp4
This PR also fixes the PUB/SUB reversal experienced in this issue #815
cc @jonaslagoni @magicmatatjahu