Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Refactor to new name asus-numberpad-driver #131

Closed
kamack38 opened this issue Jul 11, 2023 · 7 comments · Fixed by #145
Closed

[Feature Request] Refactor to new name asus-numberpad-driver #131

kamack38 opened this issue Jul 11, 2023 · 7 comments · Fixed by #145
Assignees

Comments

@kamack38
Copy link
Member

Short Description

Since the project name changed to asus-numberpad-driver the install path shouldn't be /usr/share/asus_touchpad_numpad-driver/, but it should be /usr/share/asus-numberpad-driver/

New dependencies

No

Additional Info

No response

@kamack38 kamack38 added the enhancement New feature or request label Jul 11, 2023
@ldrahnik
Copy link
Member

ldrahnik commented Jul 11, 2023

@kamack38 Agree, also systemctl service name should be refactored and maybe something else. I have no time for this now unfortunately, PR is welcome.

@ldrahnik ldrahnik changed the title [Feature Request] Change install path [Feature Request] Refactor to new name asus-numberpad-driver Jul 11, 2023
@ldrahnik ldrahnik removed their assignment Jul 11, 2023
@ldrahnik ldrahnik added refactoring and removed enhancement New feature or request labels Jul 11, 2023
@ldrahnik
Copy link
Member

ldrahnik commented Oct 15, 2023

@kamack38 Done, needs to be changed code for arch package.

@kamack38
Copy link
Member Author

I'll take care of this after Wednesday.

@kamack38
Copy link
Member Author

The AUR package should be working now.

@ldrahnik
Copy link
Member

ldrahnik commented Oct 19, 2023

@kamack38 Nice. Is possible select even unicode and non unicode layout variant? All are predefined in repository, newly.

@kamack38
Copy link
Member Author

I haven't added that, but I will ASAP. Anyway, what's the difference between a unicode layout and a non unicode one?

@ldrahnik
Copy link
Member

ldrahnik commented Oct 19, 2023

@kamack38 From install script:

NumberPad layout

Are predefined 2 variants of numberpad layouts for each laptop:
  - Standard is recommended to use, the keys except percent and hash tag are send directly but layout is not resistant to overbinding these keys to something else and that is reason why exist second version
  - Unicode send keys like unicode chars except backspace and enter using shortcut Ctrl+Shift+U+<sequence of number keys>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment