-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Expand CDMS testing #3095
Comments
The systematic search will begin with something like: from astroquery.linelists.cdms import CDMS
from astropy import units as u
sptbl = CDMS.get_species_table()
for row in sptbl:
result = CDMS.query_lines(1*u.GHz, 1*u.THz, molecule=str(row['tag']), parse_name_locally=False)
print(tag, row['molecule'], len(result)) but either CDMS is down right now or they're blocking the airport IP. |
Yeah, I tried something like this but some of my requests got timed out as well. Although I still managed to fetch transitions for most of molecules in the database. While doing that, I encountered one more bug
Here EDIT: I am not sure that only these two |
Yeap, adding just those one or two to #3094 would be enough, and this issue can be addressed in a follow-up PR that does a the exhaustive checks. |
Some notes to self:
compare to 100501:
the order, and the spacing, is completely different. CDMS may be unsupportable if they don't provide some kind of metadata about the table format.... but I'm not willing to remove support, as I use the damned thing. |
Following #3094, it is clear that there is a range of untested parameters in the CDMS module that require tests.
TODO includes:
The text was updated successfully, but these errors were encountered: