Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with notmuch v0.32 database.mail_root config #709

Open
OJFord opened this issue Jul 20, 2021 · 1 comment
Open

Incompatible with notmuch v0.32 database.mail_root config #709

OJFord opened this issue Jul 20, 2021 · 1 comment

Comments

@OJFord
Copy link

OJFord commented Jul 20, 2021

The database.mail_root config option of notmuch allows storing the notmuch indices (database.path) separately to the source directories.

By default, it falls back on database.path for backwards-compatibility, but if set astroid is unable to view threads, since it tries to load ${database.path}/${path to eml} instead of ${database.mail_root}/${path to eml} where it is actually located.

Somewhat relatedly, notmuch has defaults but astroid requires (almost all of) them to be explicitly set in config. If astroid used notmuch config get database.mail_root, then it would not be necessary to re-implement notmuch's fallback (or environment variables, etc.). It would also avoid the need to specify notmuch config location in astroid config, even when a location on notmuch's default search path is used.

@OJFord
Copy link
Author

OJFord commented Jul 26, 2021

This is due to use of notmuch_database_open, rather than the new notmuch_database_open_with_config, some more detail in vhdirk/notmuch-rs#34, but essentially the former is stuck with ignoring config in order to provide a compatible upgrade path, (so explained D. Bremner on IRC) and as a result mail_root can't be specified and is assumed to equal db_path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant