Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU options for cloud-hypervisor #157

Open
jpds opened this issue Oct 30, 2023 · 1 comment
Open

CPU options for cloud-hypervisor #157

jpds opened this issue Oct 30, 2023 · 1 comment

Comments

@jpds
Copy link
Contributor

jpds commented Oct 30, 2023

We need to expose a way for the user to add additional --cpus options at:

"--cpus" "boot=${toString vcpu}"

I tried to figure out a nice way to do this with Nix, but had to end with hard-coding it to make a machine work.

@astro
Copy link
Owner

astro commented Oct 30, 2023

I was not even aware cloud-hypervisor had that many CPU options!

To make it accessible from NixOS configuration, these hypervisor-specific bits can be exposed in hypervisor-specific NixOS options just like we already do for QEMU with microvm.qemu.extraArgs. They don't have to be as generic as extraArgs.

If you're ready to walk an extra mile with this, know that this project abstracts away specifics to present you with unified configuration of different hypervisors. It would take some time to research what capabilities can be controlled through common options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants