Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masterful implementation #1

Merged
merged 90 commits into from
Dec 26, 2024
Merged

Masterful implementation #1

merged 90 commits into from
Dec 26, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Dec 22, 2024 •
edited
Loading

  • Cache HTML output
  • Handle style bundle injections
  • Handle style bundle inlining
  • Handle bundled script injections
  • Handle FS sub-node limits
  • Handle Astro Assets generation
  • Handle props with getter (like Starlight labels for deprecation)
    • It should detect properties with getters and ignore them
  • Invalidate cache transitively
  • Compress cache
  • Trade-offs page in docs
  • Limit in-memory usage
  • Add actual docs for configuration (different services like vercel, netlify, coolify etc.)
  • Do benchmark for the 6 example sites
  • Support for export const cache = false
  • Handle Object.defineProperty edge cases

Fryuni and others added 30 commits December 21, 2024 00:28
@Fryuni
WIP
7793c9b
@Fryuni
WIP
ecd3f1f
@Fryuni
WIP
6c5c980
@Fryuni
Oh my fucking god it WORKS
c0fe796
@Fryuni
IMAGES ARE BEAUTIFUL
6a396b3 
And fast too...
@louisescher
Update docs
dd35313
@louisescher
Add proper docs
3e9c198
@louisescher
Changes
d1c0c39
@louisescher
Specify
b7fac24
@louisescher
Update
0a3b026
@TheOtterlord
Ignore proxies when resolving props
ffafbbb
@TheOtterlord
Add todo
5b135ae
@Fryuni
Release
76702d0
@Fryuni
chore: update version
2240351
@Fryuni
chore: update version
b4583e5
@Fryuni
Update things
eaa6f67
@Fryuni
Make docs a private package
1f1a84b
@Fryuni
Fix package README
6406f8e
@Fryuni
Document bundling runtime access
9506eac
@TheOtterlord
spellcheck
7076a9d
@TheOtterlord
Remove patched dependencies
68d8384
@louisescher
Set up benchmarks
967c560
@louisescher
Merge branch 'alternate/cache-definition-instead-of-render' of https:…
fdf72e1 
…//github.com/astro-expansion/domain-expansion into alternate/cache-definition-instead-of-render
@TheOtterlord
Make bench.sh executable
3854501
@louisescher
Update install and initial build commands to hide logs
4688fc7
@louisescher
Merge branch 'alternate/cache-definition-instead-of-render' of https:…
7a831e7 
…//github.com/astro-expansion/domain-expansion into alternate/cache-definition-instead-of-render
@louisescher
Stuff
1115040
@TheOtterlord
Remove starlight
4f1002b
@louisescher
Remove Dockerfile and update benchmark scripts and documentation
7d4256a
@louisescher
Merge branch 'alternate/cache-definition-instead-of-render' of https:…
2529c77 
…//github.com/astro-expansion/domain-expansion into alternate/cache-definition-instead-of-render
@Fryuni Fryuni requested a review from louisescher December 26, 2024 23:25
louisescher
louisescher approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do anything but approve this, github keeps crashing on me plz halp

@github-actions github-actions bot removed the preview label Dec 26, 2024
@Fryuni Fryuni added the enhancement New feature or request label Dec 26, 2024
@Fryuni Fryuni changed the title Complete and masterful implementation Masterful implementation Dec 26, 2024
@Fryuni Fryuni merged commit a706890 into main Dec 26, 2024
11 checks passed
@Fryuni Fryuni deleted the alternate/cache-definition-instead-of-render branch December 26, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisescher louisescher louisescher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fryuni @louisescher @TheOtterlord