Peer review #2

[miartris]

Cloned 19.00 25.2

Instructions for set up worked for me, but I had to run the main.py file directly since invoke start with poetry failed. Although it might just be my environment this could be taken into account in user instructions.

The application looks awesome and I didn't encounter any bugs.

The program is structured nicely. Documentation of functions etc. is very extensive. In some cases it's probably fine to omit or trim some of it for compactness such as in a few simple getters in Markov Player since the code itself along with type hints is very self-documenting. The class also contains a try-except block with quite a few errors that seem to not be explicitly dealt with that could be made more explicit by either handling them or detailing why not.

There is a decent amount of file handling. Maybe enough to warrant extracting the logic to a dedicated Filehandler-class. Conventions are followed nicely here with reading .env values and performing filepath operations with os functions.

I can't comment much on the algorithmic side of the program since I'm not overly familiar when it comes to Markov chain generated stuff.

Excellent work overall!