Sort imports below __all__

[JacobCoffee]

When using context UI importing in PyCharm sometimes imports get place below __all__.

I'm just wondering, even if its not "expected behavior for iSort" or whatever, if it's possible to sort this block in the event imports are below __all__.

If if TYPE_CHECKING: is below __all__, we get the same behavior - but if it is above then things import correctly.

Maybe we could sort the blocks so that we have

1. Imports
2. if TYPE_CHECKING:
3. __all__
4. bad code
   ?

Before:

from __future__ import annotations

import click
from rich import get_console

from src.lib import _quote

__all__ = [
    "some_func",
    "run",
]

Using the little context UI to import:

The now imported and Ruff sorted block:

from __future__ import annotations

import click
from rich import get_console

from src.lib import _quote

__all__ = [
    "some_func",
    "run",
]

from src.lib import logging

logger = logging.getLogger(__name__)

However, when I am using if TYPE_CHECKING: (above __all__ only, below is the same behavior) it correctly imports.

Doing the same thing but with `if TYPE_CHECKING:`:

from __future__ import annotations

import click
from rich import get_console

from src.lib import _quote
from src.lib import logging

if TYPE_CHECKING:
    from java import bad

__all__ = [
    "some_func",
    "run",
]

logger = logging.getLogger(__name__)

[zanieb]

Interesting. I'm not sure if we can reliably sort imports that are in separate blocks. This sounds like a PyCharm bug though?

[JacobCoffee]

I'm not sure if we can reliably sort imports that are in separate blocks.
darn 😬

Yeah I think so... it surely isn't an issue in the correct editor (neovim), or VSCode 🙁

[JacobCoffee]

https://youtrack.jetbrains.com/issue/PY-63973 this was reproduced on Jetbrains' side.