Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version in conda-forge CI is 0.0.0 #73

Open
davidbrochart opened this issue Apr 21, 2023 · 6 comments · May be fixed by #74
Open

Version in conda-forge CI is 0.0.0 #73

davidbrochart opened this issue Apr 21, 2023 · 6 comments · May be fixed by #74

Comments

@davidbrochart
Copy link
Contributor

When installing Asphalt in the conda-forge CI, we get:

Successfully installed asphalt-0.0.0

This prevents using pip check in jupyverse's feedstock:

jupyverse-api 0.1.4 has requirement asphalt<5,>=4.11.0, but you have asphalt 0.0.0.
jupyverse-api 0.1.4 has requirement asphalt-web[fastapi]<2,>=1.1.0, but you have asphalt-web 0.0.0.
asphalt-web 0.0.0 has requirement asphalt~=4.8, but you have asphalt 0.0.0.
asphalt 0.0.0 has requirement asyncio-extras~=1.3, but you have asyncio-extras 0.0.0.

I cannot reproduce locally, but maybe there is an issue with setuptools_scm?

@agronholm
Copy link
Member

I'm no expert in Anaconda matters, but it would appear that the build was done not from a git checkout, but an sdist?

@davidbrochart
Copy link
Contributor Author

Yes, that's the preferred way of getting sources for Python packages on conda-forge.

@agronholm
Copy link
Member

But setuptools_scm gets the version from git tags, so the sdist would not work properly. So either I should stop publishing sdists entirely, or find a mechanism in setuptools_scm that writes the version information in a file where setuptools could find it when installing from sdist?

@davidbrochart
Copy link
Contributor Author

What about switching to hatch?

@agronholm
Copy link
Member

I'm willing to entertain the idea, but this would probably require a PR because right now I have too much on my plate already with typeguard and anyio.

@davidbrochart
Copy link
Contributor Author

No problem, maybe I'll try to do it.

@davidbrochart davidbrochart linked a pull request Apr 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants