From c46a25697526111c9f6df655a48c2560905c4b72 Mon Sep 17 00:00:00 2001 From: Jingsong Date: Thu, 20 Jun 2024 18:03:07 +0800 Subject: [PATCH] [minor] Add comments for tag without timeRetained --- .../src/main/java/org/apache/paimon/utils/TagManager.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java b/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java index 6c59ef53cc72..23675bf9cf58 100644 --- a/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java +++ b/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java @@ -102,6 +102,11 @@ public void createTag( } else { Path newTagPath = tagPath(tagName); try { + // When timeRetained is not defined, please do not write the tagCreatorTime field, + // as this will cause older versions (<= 0.7) of readers to be unable to read this + // tag. + // When timeRetained is defined, it is fine, because timeRetained is the new + // feature. fileIO.writeFileUtf8( newTagPath, timeRetained != null